From: Cyril Hrubis <chrubis@suse.cz>
To: Ma Xinjian <maxj.fnst@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] posix/conformance/interfaces/sem_timedwait/2-1: add _GNU_SOURCE define
Date: Tue, 10 Sep 2024 12:11:53 +0200 [thread overview]
Message-ID: <ZuAbaUHY8ZPjN5ey@yuki.lan> (raw)
In-Reply-To: <20240910094755.57438-1-maxj.fnst@fujitsu.com>
Hi!
> To get rid of error "‘MAP_ANONYMOUS’ undeclared (first use in this function)"
> on some systems (Fedora 37, etc).
That does not sound right, the open posix testsuite must not depend on
anything GNU specific.
Also MAP_ANONYMOUS is requiered to be there by POSIX so setting
_GNU_SOURCE does not seem to be a good solution.
> Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
> ---
> .../conformance/interfaces/sem_timedwait/2-1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/2-1.c b/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/2-1.c
> index 2eca8dff6..4ccef7261 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/2-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/sem_timedwait/2-1.c
> @@ -11,6 +11,7 @@
> */
>
>
> +#define _GNU_SOURCE
> #include <stdio.h>
> #include <errno.h>
> #include <unistd.h>
> --
> 2.42.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-09-10 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 9:47 [LTP] [PATCH] posix/conformance/interfaces/sem_timedwait/2-1: add _GNU_SOURCE define Ma Xinjian via ltp
2024-09-10 10:11 ` Cyril Hrubis [this message]
2024-09-13 4:07 ` Xinjian Ma (Fujitsu) via ltp
2024-09-17 14:16 ` Cyril Hrubis
2024-09-19 3:38 ` Xinjian Ma (Fujitsu) via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuAbaUHY8ZPjN5ey@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=maxj.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox