From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2A1BEDE99D for ; Tue, 10 Sep 2024 15:28:34 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 5FF863C1BA1 for ; Tue, 10 Sep 2024 17:28:32 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C75203C1B5A for ; Tue, 10 Sep 2024 17:28:15 +0200 (CEST) Authentication-Results: in-5.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 55BC660D49A for ; Tue, 10 Sep 2024 17:28:14 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2E5241F7D4; Tue, 10 Sep 2024 15:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725982094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qd/QM8hMjJSx+/OnO2QTI6Sdm1M7uA/Vvb0iR89Ymrc=; b=XIp9JF1uBwBMYmiqLnsnrKlWxyvDp2QwvVsb3MWDgsqWgWXxPylpWWaR/kzJqg6lEC3f27 2UUs972Mw+Ih5LmX+xDrTIlskkn8f/p6BEYJPd1i0P0YEVPrZRs3VtVNFXZPm/mq47zYGG gzD2QhHN4HKDLN7mFXdIOtF3l80/cIM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725982094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qd/QM8hMjJSx+/OnO2QTI6Sdm1M7uA/Vvb0iR89Ymrc=; b=RgwhGslacSVv/lmf+CNYXa2GMGcYCSFOa33mb2gzmBe1YFyKLEVsJbN7xKHyG/VzS292sH J6gTVdU+Ys3iojBg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725982094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qd/QM8hMjJSx+/OnO2QTI6Sdm1M7uA/Vvb0iR89Ymrc=; b=XIp9JF1uBwBMYmiqLnsnrKlWxyvDp2QwvVsb3MWDgsqWgWXxPylpWWaR/kzJqg6lEC3f27 2UUs972Mw+Ih5LmX+xDrTIlskkn8f/p6BEYJPd1i0P0YEVPrZRs3VtVNFXZPm/mq47zYGG gzD2QhHN4HKDLN7mFXdIOtF3l80/cIM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725982094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qd/QM8hMjJSx+/OnO2QTI6Sdm1M7uA/Vvb0iR89Ymrc=; b=RgwhGslacSVv/lmf+CNYXa2GMGcYCSFOa33mb2gzmBe1YFyKLEVsJbN7xKHyG/VzS292sH J6gTVdU+Ys3iojBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 169EB13A3A; Tue, 10 Sep 2024 15:28:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NlLEBI5l4GY6RQAAD6G6ig (envelope-from ); Tue, 10 Sep 2024 15:28:14 +0000 Date: Tue, 10 Sep 2024 17:26:59 +0200 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20240902-fcntl4_refactoring-v4-0-4446517da427@suse.com> <20240902-fcntl4_refactoring-v4-1-4446517da427@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240902-fcntl4_refactoring-v4-1-4446517da427@suse.com> X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:email] X-Virus-Scanned: clamav-milter 1.0.3 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4 1/2] Add silent macros for TST_EXP_EQ_* X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +#define TST_EXP_EQ_SILENT_(VAL_A, SVAL_A, VAL_B, SVAL_B, TYPE, PFS) do { \ > + TYPE tst_tmp_a__ = VAL_A; \ > + TYPE tst_tmp_b__ = VAL_B; \ > + \ > + TST_PASS = 0; \ > + \ > + if (tst_tmp_a__ != tst_tmp_b__) { \ > + tst_res_(__FILE__, __LINE__, TFAIL, \ > + SVAL_A " (" PFS ") != " SVAL_B " (" PFS ")", \ > + tst_tmp_a__, tst_tmp_b__); \ > + break; \ > + } \ > + \ I would probably do here: } else { TST_PASS = 1; } Because it's a bit more readable. Also you did messed up the alignment of the \ at the end. Apart from these minor things I do not see anything wrong here. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp