From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 2/2] Rewrite fcnt14 test
Date: Tue, 10 Sep 2024 17:48:26 +0200 [thread overview]
Message-ID: <ZuBqSjIK4z25dEfD@yuki.lan> (raw)
In-Reply-To: <20240902-fcntl4_refactoring-v4-2-4446517da427@suse.com>
Hi!
Just minor thing the subject has 'fcnt14' instead of 'fcntl14'.
> ---
> runtest/syscalls | 4 +-
> testcases/kernel/syscalls/fcntl/fcntl14.c | 1253 +++++------------------------
> 2 files changed, 211 insertions(+), 1046 deletions(-)
>
> diff --git a/runtest/syscalls b/runtest/syscalls
> index a9fc8c432..1e4c41d17 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -312,8 +312,8 @@ fcntl12 fcntl12
> fcntl12_64 fcntl12_64
> fcntl13 fcntl13
> fcntl13_64 fcntl13_64
> -fcntl14 fcntl14
> -fcntl14_64 fcntl14_64
> +fcntl14_01 fcntl14
> +fcntl14_01_64 fcntl14_64
We should get rid of the 01 if there is only single variant now.
The rest looks fine.
With these fixed: Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-09-10 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 12:45 [LTP] [PATCH v4 0/2] fcntl14 refactoring Andrea Cervesato
2024-09-02 12:45 ` [LTP] [PATCH v4 1/2] Add silent macros for TST_EXP_EQ_* Andrea Cervesato
2024-09-10 15:26 ` Cyril Hrubis
2024-09-02 12:45 ` [LTP] [PATCH v4 2/2] Rewrite fcnt14 test Andrea Cervesato
2024-09-10 15:48 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuBqSjIK4z25dEfD@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox