Re: [LTP] [PATCH v4 06/13] Add statmount01 test

Cyril Hrubis
2024-10-02T14:46:57Z

Hi!
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Copyright (C) 2024 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
> + */
> +
> +#ifndef STATMOUNT_H

Here as well, missing #define STATMOUNT_H

> +#define _GNU_SOURCE
> +
> +#include "tst_test.h"
> +#include "lapi/mount.h"
> +#include "lapi/syscalls.h"
> +
> +static inline int statmount(uint64_t mnt_id, uint64_t mask, struct statmount *buf,
> + size_t bufsize, unsigned int flags)
> +{
> + struct mnt_id_req req = {
> + .size = MNT_ID_REQ_SIZE_VER0,
> + .mnt_id = mnt_id,
> + .param = mask,
> + };
> +
> + return tst_syscall(__NR_statmount, &req, buf, bufsize, flags);
> +}
> +
> +#endif
> diff --git a/testcases/kernel/syscalls/statmount/statmount01.c b/testcases/kernel/syscalls/statmount/statmount01.c
> new file mode 100644
> index 000000000..95dac5c92
> --- /dev/null
> +++ b/testcases/kernel/syscalls/statmount/statmount01.c
> @@ -0,0 +1,82 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2024 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This test verifies that statmount() is working with no mask flags.
> + *
> + * [Algorithm]
> + *
> + * - create a mount point
> + * - run statmount() on the mount point without giving any mask
> + * - read results and check that mask and size are correct
> + */
> +
> +#define _GNU_SOURCE
> +
> +#include "statmount.h"
> +#include "lapi/stat.h"
> +#include "lapi/sched.h"
> +
> +#define MNTPOINT "mntpoint"
> +
> +static uint64_t root_id;
> +static struct statmount *st_mount;
> +
> +static void run(void)
> +{
> + memset(st_mount, 0, sizeof(struct statmount));
> +
> + TST_EXP_PASS(statmount(root_id, 0, st_mount, sizeof(struct statmount), 0));
> +
> + if (TST_RET == -1)
> + return;

Here if (!TST_PASS) as well.

> + TST_EXP_EQ_LI(st_mount->size, sizeof(struct statmount));
> + TST_EXP_EQ_LI(st_mount->mask, 0);
> + TST_EXP_EQ_LI(st_mount->sb_dev_major, 0);
> + TST_EXP_EQ_LI(st_mount->sb_dev_minor, 0);
> + TST_EXP_EQ_LI(st_mount->sb_magic, 0);
> + TST_EXP_EQ_LI(st_mount->sb_flags, 0);
> + TST_EXP_EQ_LI(st_mount->fs_type, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_id, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_parent_id, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_id_old, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_parent_id_old, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_attr, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_propagation, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_peer_group, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_master, 0);
> + TST_EXP_EQ_LI(st_mount->propagate_from, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_root, 0);
> + TST_EXP_EQ_LI(st_mount->mnt_point, 0);
> +}
> +
> +static void setup(void)
> +{
> + struct ltp_statx sx;
> +
> + SAFE_STATX(AT_FDCWD, MNTPOINT, 0, STATX_MNT_ID_UNIQUE, &sx);
> +
> + root_id = sx.data.stx_mnt_id;

Maybe this should be called mntpoint_id to make it less confusing.

> +}
> +
> +static struct tst_test test = {
> + .test_all = run,
> + .setup = setup,
> + .min_kver = "6.8",
> + .mount_device = 1,
> + .mntpoint = MNTPOINT,
> + .all_filesystems = 1,
> + .skip_filesystems = (const char *const []) {
> + "fuse",
> + NULL
> + },

I'm not sure that it makes sense to run this test for all filesystems,
it's just at test that the returned buffer is untouched/cleared if we do
not request any information. I bet that it does not call any filesystem
specific code at all.

> + .bufs = (struct tst_buffers []) {
> + {&st_mount, .size = sizeof(struct statmount)},
> + {}
> + }
> +};

--
Cyril Hrubis
chrubis@suse.cz