Re: [LTP] [PATCH v4 04/13] Add listmount01 test

Cyril Hrubis
2024-10-02T14:06:41Z

Hi!
> This test verifies that listmount() is properly recognizing a mounted
> root directory using LSMT_ROOT flag.
>
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
> runtest/syscalls | 2 +
> testcases/kernel/syscalls/listmount/.gitignore | 1 +
> testcases/kernel/syscalls/listmount/Makefile | 7 +++
> testcases/kernel/syscalls/listmount/listmount.h | 26 ++++++++++
> testcases/kernel/syscalls/listmount/listmount01.c | 63 +++++++++++++++++++++++
> 5 files changed, 99 insertions(+)
>
> diff --git a/runtest/syscalls b/runtest/syscalls
> index a9fc8c432..48db6259b 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -730,6 +730,8 @@ linkat02 linkat02
>
> listen01 listen01
>
> +listmount01 listmount01
> +
> listxattr01 listxattr01
> listxattr02 listxattr02
> listxattr03 listxattr03
> diff --git a/testcases/kernel/syscalls/listmount/.gitignore b/testcases/kernel/syscalls/listmount/.gitignore
> new file mode 100644
> index 000000000..5257b298c
> --- /dev/null
> +++ b/testcases/kernel/syscalls/listmount/.gitignore
> @@ -0,0 +1 @@
> +listmount01
> diff --git a/testcases/kernel/syscalls/listmount/Makefile b/testcases/kernel/syscalls/listmount/Makefile
> new file mode 100644
> index 000000000..8cf1b9024
> --- /dev/null
> +++ b/testcases/kernel/syscalls/listmount/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (C) 2024 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
> +
> +top_srcdir ?= ../../../..
> +
> +include $(top_srcdir)/include/mk/testcases.mk
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> diff --git a/testcases/kernel/syscalls/listmount/listmount.h b/testcases/kernel/syscalls/listmount/listmount.h
> new file mode 100644
> index 000000000..93766cd33
> --- /dev/null
> +++ b/testcases/kernel/syscalls/listmount/listmount.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Copyright (C) 2024 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
> + */
> +
> +#ifndef LISTMOUNT_H
> +
> +#define _GNU_SOURCE
> +
> +#include "tst_test.h"
> +#include "lapi/mount.h"
> +#include "lapi/syscalls.h"
> +
> +static inline ssize_t listmount(uint64_t mnt_id, uint64_t last_mnt_id,
> + uint64_t list[], size_t num, unsigned int flags)
> +{
> + struct mnt_id_req req = {
> + .size = MNT_ID_REQ_SIZE_VER0,
> + .mnt_id = mnt_id,
> + .param = last_mnt_id,
> + };
> +
> + return tst_syscall(__NR_listmount, &req, list, num, flags);
> +}
> +
> +#endif
> diff --git a/testcases/kernel/syscalls/listmount/listmount01.c b/testcases/kernel/syscalls/listmount/listmount01.c
> new file mode 100644
> index 000000000..ab74b776b
> --- /dev/null
> +++ b/testcases/kernel/syscalls/listmount/listmount01.c
> @@ -0,0 +1,63 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2024 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This test verifies that listmount() is properly recognizing a mounted
> + * root directory using LSMT_ROOT flag.
> + *
> + * [Algorithm]
> + *
> + * - move into a new unshared namespace
> + * - mount() a root inside temporary folder and get its mount ID
> + * - get list of mounted IDs using listmount(LSMT_ROOT, ..)
> + * - verify that the root mount ID is the only mount ID present inside the list
> + */
> +
> +#define _GNU_SOURCE
> +
> +#include "listmount.h"
> +#include "lapi/stat.h"
> +#include "lapi/sched.h"
> +
> +#define MNTPOINT "mntpoint"
> +#define LISTSIZE 32
> +
> +static uint64_t root_id;
> +
> +static void run(void)
> +{
> + uint64_t list[LISTSIZE];
> +
> + TST_EXP_POSITIVE(listmount(LSMT_ROOT, 0, list, LISTSIZE, 0));
> + if (TST_RET == -1)
> + return;

This is purely cosmetic but this should be if (!TST_PASS).

The rest looks good:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

--
Cyril Hrubis
chrubis@suse.cz