Re: [LTP] [PATCH v4 05/13] Add listmount02 test

Cyril Hrubis
2024-10-02T14:39:03Z

Hi!
> +static void run(void)
> +{
> + ssize_t ret;
> + size_t id, tot_ids, count = 0;
> + uint64_t mount_ids[LISTSIZE];
> + uint64_t list[LISTSIZE];
> +
> + for (int i = 0; i < BIND_MOUNTS; i++)
> + SAFE_MOUNT("/", "/", NULL, MS_BIND, NULL);
> +
> + tst_res(TINFO, "Reading all %d mount IDs in once", LISTSIZE);
> +
> + TST_EXP_POSITIVE(listmount(LSMT_ROOT, 0, mount_ids, LISTSIZE, 0));
> + if (TST_RET == -1)
> + goto end;

Again this should be if (!TST_PASS)

Otherwise:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

--
Cyril Hrubis
chrubis@suse.cz