public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: 杨晓 <ice_yangxiao@163.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/{fanotify17, getxattr05}: simplify code by using save_restore
Date: Mon, 23 Sep 2024 10:16:24 +0200	[thread overview]
Message-ID: <ZvEj2GHW8komVKfX@yuki.lan> (raw)
In-Reply-To: <5886c6f2.1ce6.19213255e77.Coremail.ice_yangxiao@163.com>

Hi!
> If more than 10 user namspaces is currently used on system, it is still successfully to set
> max_user_namespaces to 10.  However, these tests fail with ENOSPC. for example:
> # lsns -t user -l -n | wc -l
> 17
> 
> root@fedora40:~/ltp/testcases/kernel/syscalls/fanotify# ./fanotify17
> ...
> fanotify17.c:174: TINFO: Test #0: Global groups limit in init user ns
> fanotify17.c:130: TPASS: Created 128 groups - below groups limit (128)
> fanotify17.c:174: TINFO: Test #1: Global groups limit in privileged user ns
> fanotify17.c:154: TFAIL: unshare(CLONE_NEWUSER) failed: ENOSPC (28)
> tst_test.c:452: TBROK: Invalid child (6958) exit value 1
> 
> 
> 
> Just try to fix the issue by increasing the setting of max_user_namespaces.
> BTW, it may be better to get the number of user namespaces in use and then add 10.

Such change should be ideally in a separate patch with this explanation
and not hidden in a patch that is supposedly just moving the code that
restores the original value.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2024-09-23  8:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  2:58 [LTP] [PATCH] syscalls/{fanotify17, getxattr05}: simplify code by using save_restore Xiao Yang
2024-09-17 11:10 ` Cyril Hrubis
2024-09-21  5:54   ` 杨晓
2024-09-23  8:16     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvEj2GHW8komVKfX@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ice_yangxiao@163.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox