Re: [LTP] [PATCH] Fix ioctl_ficlone on XFS without reflink support

Martin Doucha
2024-09-27T14:41:24Z

On 26. 09. 24 13:57, Cyril Hrubis wrote:
> I suppose that we need to add .mkfs_ver string to the struct tst_fs and
> possibly .kernel_ver as well so that we can add both checks to the
> structures as:
>
> {
> .type = "xfs",
> .mkfs_ver = ">= 5.1.0",
> .kernel_ver = ">= 4.9.0",
> ...
> }

It'd be simpler to add .skip_if_unsupported flag to struct tst_fs and
then simply TCONF the single filesystem if mount() returns EOPNOTSUPP.
That way we don't need hardcoded version checks for the kernel. MKFS
versions checks would still be needed, though.

But since this would turn into a fairly large change right before
release, I'd recommend reverting the ioctl_ficlone tests before the
release and merging them back after.

--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic