Re: [LTP] [PATCH] Fix ioctl_ficlone on XFS without reflink support

Cyril Hrubis
2024-09-27T07:51:19Z

Hi!
> >> I'm not sure if it makes sense to add this feature if we already have
> >> .needs_cmd and .min_kver. It's better to keep things simple in this case.
> > That will obvioiusly not work because we need to skip just a single
> > filesystem not the whole test...
> >
> Right, so the discussion turns into what mkfs.* commands we want to
> support, because we need to create a parser for each one of them and at
> the moment I see mkfs.ext4 only.

I would write the code "on demand" so I would implement xfs parser
beacause it's needed now.