From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 11/16] Add statmount05 test
Date: Tue, 8 Oct 2024 14:03:07 +0200 [thread overview]
Message-ID: <ZwUfe1rysrK2MfDi@yuki.lan> (raw)
In-Reply-To: <20241008-listmount_statmount-v5-11-66f4e1a9e7db@suse.com>
Hi!
> +static void test_mount_root(void)
> +{
> + tst_res(TINFO, "Testing STATMOUNT_MNT_ROOT");
> +
> + char *last_root;
> +
> + memset(st_mount, 0, SM_SIZE);
> +
> + TST_EXP_PASS(statmount(root_id, STATMOUNT_MNT_ROOT, st_mount,
> + SM_SIZE, 0));
> +
> + if (!TST_PASS)
> + return;
> +
> + last_root = strrchr(mnt_root, '/');
Wouldn't last_root = strrchr(DIRA, '/') produce the same result?
I'm just wondering why MNT_ROOT is relative and MNT_POINT is absolute
here.
> + TST_EXP_EQ_LI(st_mount->mask, STATMOUNT_MNT_ROOT);
> + TST_EXP_EQ_STR(st_mount->str + st_mount->mnt_root, last_root);
> +}
Otherwise:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-10-08 12:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 9:41 [LTP] [PATCH v5 00/16] statmount/listmount testing suites Andrea Cervesato
2024-10-08 9:41 ` [LTP] [PATCH v5 01/16] Add SAFE_STATX macro Andrea Cervesato
2024-10-08 9:41 ` [LTP] [PATCH v5 02/16] Add TST_EXP_EQ_STR macro Andrea Cervesato
2024-10-08 9:41 ` [LTP] [PATCH v5 03/16] Add listmount/statmount syscalls Andrea Cervesato
2024-10-08 9:41 ` [LTP] [PATCH v5 04/16] Add listmount/statmount fallback declarations Andrea Cervesato
2024-10-08 9:41 ` [LTP] [PATCH v5 05/16] Add listmount01 test Andrea Cervesato
2024-10-08 9:41 ` [LTP] [PATCH v5 06/16] Add listmount02 test Andrea Cervesato
2024-10-08 9:42 ` [LTP] [PATCH v5 07/16] Add statmount01 test Andrea Cervesato
2024-10-08 11:54 ` Cyril Hrubis
2024-10-08 9:42 ` [LTP] [PATCH v5 08/16] Add statmount02 test Andrea Cervesato
2024-10-08 9:42 ` [LTP] [PATCH v5 09/16] Add statmount03 test Andrea Cervesato
2024-10-08 9:42 ` [LTP] [PATCH v5 10/16] Add statmount04 test Andrea Cervesato
2024-10-08 9:42 ` [LTP] [PATCH v5 11/16] Add statmount05 test Andrea Cervesato
2024-10-08 12:03 ` Cyril Hrubis [this message]
2024-10-08 13:57 ` Andrea Cervesato via ltp
2024-10-08 14:11 ` Andrea Cervesato via ltp
2024-10-08 9:42 ` [LTP] [PATCH v5 12/16] Add statmount06 test Andrea Cervesato
2024-10-08 9:42 ` [LTP] [PATCH v5 13/16] Add statmount07 test Andrea Cervesato
2024-10-08 12:27 ` Cyril Hrubis
2024-10-08 9:42 ` [LTP] [PATCH v5 14/16] Add statmount08 test Andrea Cervesato
2024-10-08 12:05 ` Cyril Hrubis
2024-10-08 9:42 ` [LTP] [PATCH v5 15/16] Add listmount03 test Andrea Cervesato
2024-10-08 12:08 ` Cyril Hrubis
2024-10-08 9:42 ` [LTP] [PATCH v5 16/16] Add listmount04 test Andrea Cervesato
2024-10-08 15:00 ` Cyril Hrubis
2024-10-08 15:33 ` Andrea Cervesato via ltp
2024-10-08 15:39 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwUfe1rysrK2MfDi@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox