From: Cyril Hrubis <chrubis@suse.cz>
To: David Hildenbrand <david@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 3/3] move_pages04: convert to new test API
Date: Thu, 17 Oct 2024 17:27:32 +0200 [thread overview]
Message-ID: <ZxEs5E4vwvRr7DTN@yuki.lan> (raw)
In-Reply-To: <20241008135934.2491333-4-david@redhat.com>
Hi!
> +static struct tst_test test = {
> + .test_all = run,
> + .setup = setup,
> + .max_runtime = 120,
This seems to be a bit excessive, generally tests that do run in less
than a second are not supposed to set this field.
Is there any reason for this to be there? If not I can remove this line
along with fixing the typo found by Jan and fix a bit of the formatting
for the documentation comment that is actually parsed by asciidoc before
applying the changes.
> + .tags = (const struct tst_tag[]) {
> + {"linux-git", "d899844e9c98"},
> + {"linux-git", "7dff875c9436"},
> + {}
> + }
> +};
> --
> 2.46.1
>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-10-17 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 13:59 [LTP] [PATCH v2 0/3] move_pages04: fixes and improvements David Hildenbrand
2024-10-08 13:59 ` [LTP] [PATCH v2 1/3] move_pages04: check for "invalid area", "no page mapped" and "shared zero page mapped" David Hildenbrand
2024-10-08 13:59 ` [LTP] [PATCH v2 2/3] move_pages04: remove special-casing for kernels < 4.3 David Hildenbrand
2024-10-08 13:59 ` [LTP] [PATCH v2 3/3] move_pages04: convert to new test API David Hildenbrand
2024-10-17 15:27 ` Cyril Hrubis [this message]
2024-10-17 15:30 ` David Hildenbrand
2024-10-17 17:47 ` Cyril Hrubis
2024-10-09 9:44 ` [LTP] [PATCH v2 0/3] move_pages04: fixes and improvements Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxEs5E4vwvRr7DTN@yuki.lan \
--to=chrubis@suse.cz \
--cc=david@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox