From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: Print failure hints only once to reduce log duplication
Date: Wed, 30 Oct 2024 13:15:32 +0100 [thread overview]
Message-ID: <ZyIjZGIpFlFqLm42@yuki.lan> (raw)
In-Reply-To: <ZyIjHUuNFviz47gx@yuki.lan>
Hi!
> > The LTP test currently prints failure hints multiple times if a test
> > encounters several TFAIL or TBROK results. This leads to unnecessarily
> > verbose and duplicated logs.
> >
> > This patch modifies the `print_failure_hints()` function to ensure that
> > failure hints are printed only once per test run. By setting `show_failure_hints`
> > to 0 after the first print, subsequent calls to `print_failure_hints()`
> > will not produce redundant output.
>
> Hmm, we do call print_failure_hints() from do_exit() that calls exit()
> at the end of the function. We shouldn't print the hints twice, what do
> I miss?
Ah, right, we have two if () conditions that call the function in there,
so yes, we may print it twice.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-10-30 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 8:45 [LTP] [PATCH] lib: Print failure hints only once to reduce log duplication Li Wang
2024-10-30 12:06 ` Petr Vorel
2024-10-30 12:14 ` Cyril Hrubis
2024-10-30 12:15 ` Cyril Hrubis [this message]
2024-10-31 2:33 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyIjZGIpFlFqLm42@yuki.lan \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox