[LTP] [PATCH] lib: Print failure hints only once to reduce log duplication

[LTP] [PATCH] lib: Print failure hints only once to reduce log duplication

[Li Wang]

The LTP test currently prints failure hints multiple times if a test
encounters several TFAIL or TBROK results. This leads to unnecessarily
verbose and duplicated logs.

This patch modifies the `print_failure_hints()` function to ensure that
failure hints are printed only once per test run. By setting `show_failure_hints`
to 0 after the first print, subsequent calls to `print_failure_hints()`
will not produce redundant output.

Fixes: 701212f08 ("Disable failure hints before we actually run the test")
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Cyril Hrubis <chrubis@suse.cz>
---
 lib/tst_test.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/tst_test.c b/lib/tst_test.c
index d942a91f1..8db554dea 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -911,6 +911,8 @@ static void print_failure_hints(void)
 	print_failure_hint("musl-git", "missing musl fixes", MUSL_GIT_URL);
 	print_failure_hint("CVE", "vulnerable to CVE(s)", CVE_DB_URL);
 	print_failure_hint("known-fail", "hit by known kernel failures", NULL);
+
+	show_failure_hints = 0;
 }
 
 static void do_exit(int ret)
-- 
2.46.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: Print failure hints only once to reduce log duplication

[Petr Vorel]

Hi all,

> The LTP test currently prints failure hints multiple times if a test
> encounters several TFAIL or TBROK results. This leads to unnecessarily
> verbose and duplicated logs.

> This patch modifies the `print_failure_hints()` function to ensure that
> failure hints are printed only once per test run. By setting `show_failure_hints`
> to 0 after the first print, subsequent calls to `print_failure_hints()`
> will not produce redundant output.

> Fixes: 701212f08 ("Disable failure hints before we actually run the test")
> Signed-off-by: Li Wang <liwang@redhat.com>
> Cc: Cyril Hrubis <chrubis@suse.cz>
...

> +++ b/lib/tst_test.c
> @@ -911,6 +911,8 @@ static void print_failure_hints(void)
>  	print_failure_hint("musl-git", "missing musl fixes", MUSL_GIT_URL);
>  	print_failure_hint("CVE", "vulnerable to CVE(s)", CVE_DB_URL);
>  	print_failure_hint("known-fail", "hit by known kernel failures", NULL);
> +
> +	show_failure_hints = 0;

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: Print failure hints only once to reduce log duplication

[Cyril Hrubis]

Hi!
> The LTP test currently prints failure hints multiple times if a test
> encounters several TFAIL or TBROK results. This leads to unnecessarily
> verbose and duplicated logs.
> 
> This patch modifies the `print_failure_hints()` function to ensure that
> failure hints are printed only once per test run. By setting `show_failure_hints`
> to 0 after the first print, subsequent calls to `print_failure_hints()`
> will not produce redundant output.

Hmm, we do call print_failure_hints() from do_exit() that calls exit()
at the end of the function. We shouldn't print the hints twice, what do
I miss?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: Print failure hints only once to reduce log duplication

[Cyril Hrubis]

Hi!
> > The LTP test currently prints failure hints multiple times if a test
> > encounters several TFAIL or TBROK results. This leads to unnecessarily
> > verbose and duplicated logs.
> > 
> > This patch modifies the `print_failure_hints()` function to ensure that
> > failure hints are printed only once per test run. By setting `show_failure_hints`
> > to 0 after the first print, subsequent calls to `print_failure_hints()`
> > will not produce redundant output.
> 
> Hmm, we do call print_failure_hints() from do_exit() that calls exit()
> at the end of the function. We shouldn't print the hints twice, what do
> I miss?

Ah, right, we have two if () conditions that call the function in there,
so yes, we may print it twice.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: Print failure hints only once to reduce log duplication

[Li Wang]

On Wed, Oct 30, 2024 at 8:15 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > > The LTP test currently prints failure hints multiple times if a test
> > > encounters several TFAIL or TBROK results. This leads to unnecessarily
> > > verbose and duplicated logs.
> > >
> > > This patch modifies the `print_failure_hints()` function to ensure that
> > > failure hints are printed only once per test run. By setting
> `show_failure_hints`
> > > to 0 after the first print, subsequent calls to `print_failure_hints()`
> > > will not produce redundant output.
> >
> > Hmm, we do call print_failure_hints() from do_exit() that calls exit()
> > at the end of the function. We shouldn't print the hints twice, what do
> > I miss?
>
> Ah, right, we have two if () conditions that call the function in there,
> so yes, we may print it twice.
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
>

Pushed, thank you both.

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp