public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 1/3] Refactor regen.sh script to generate syscalls
Date: Wed, 30 Oct 2024 18:43:36 +0100	[thread overview]
Message-ID: <ZyJwSAHQzUyubmh_@yuki.lan> (raw)
In-Reply-To: <4e4ff14e-43d8-4a97-8dd6-f8609cd38404@suse.com>

Hi!
> > This will generate multiple fallback definitions, one per architecture
> > for common syscall, there was a good reason why these files were parsed
> > by awk with sort -u
> I wrote the code a few weeks ago, so I needed to read it again to 
> understand the reason.
> 
> If you take a look at the drop_bad_entries() and generate_tables() you 
> will see that `sort` command is used to remove duplicates and to sort 
> the entire list per architecture.

No no, this is the code that generates the actuall LTP header and what
you do here is:

	for each architecture:
		for each syscall in architecture:
			generate fallback with invalid value


And what you need to do is:

	read all syscall names for all architectures and do sort -u then
	generate fallback with invalid value


-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-10-30 17:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  8:52 [LTP] [PATCH v5 0/3] Automatically generate syscalls.h Andrea Cervesato
2024-10-30  8:53 ` [LTP] [PATCH v5 1/3] Refactor regen.sh script to generate syscalls Andrea Cervesato
2024-10-30 13:47   ` Cyril Hrubis
2024-10-30 14:20     ` Andrea Cervesato via ltp
2024-10-30 17:43       ` Cyril Hrubis [this message]
2024-10-30 14:49   ` Petr Vorel
2024-10-30 15:34     ` Andrea Cervesato via ltp
2024-10-30 16:49       ` Petr Vorel
2024-10-30  8:53 ` [LTP] [PATCH v5 2/3] Add script to generate arch(s) dependant syscalls Andrea Cervesato
2024-10-30 14:04   ` Cyril Hrubis
2024-10-30 15:15   ` Petr Vorel
2024-10-30 15:24     ` Andrea Cervesato via ltp
2024-10-30  8:53 ` [LTP] [PATCH v5 3/3] Delete obsolete strip_syscall.awk file Andrea Cervesato
2024-10-30 14:04   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyJwSAHQzUyubmh_@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox