From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E21BD2C139 for ; Tue, 5 Nov 2024 15:26:32 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 0E0403D2768 for ; Tue, 5 Nov 2024 16:26:31 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 384DB3D26E8 for ; Tue, 5 Nov 2024 16:26:14 +0100 (CET) Authentication-Results: in-3.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.130; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id B4A0F1BE7A51 for ; Tue, 5 Nov 2024 16:26:13 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8C6BD21ACF; Tue, 5 Nov 2024 15:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730820372; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hWcndDAH9enw8rMuBtz8GGxG4LoX2GMqrDgIeyZxpJ4=; b=Tr+3PbAaYhwrog3g+Vtk3WL7hIewWH7FM6Rl8DFVEWvDlFDZwzVk47aPqVCfXakrrOP8NS ClDGk/qxLMeeuMjQSdYbhQmClLr649zxsd7IgQmnB3Au8IXc+eAI+kE7ddbwY57vuGExwp pkhYYMcKcpRUrbipgk6PeFBk3jaXBDk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730820372; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hWcndDAH9enw8rMuBtz8GGxG4LoX2GMqrDgIeyZxpJ4=; b=OY6C9vUuFjiroKSesgb4Yn9k1KahRqwByA0MjTu9HZZlJaxFcLeXH9Bt6m8kInkFiyAptD sKV4e8XUk2bUecBw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730820371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hWcndDAH9enw8rMuBtz8GGxG4LoX2GMqrDgIeyZxpJ4=; b=q9K4o4XIy5kekBaPPonzIeKXsk5sc/QfKdB64uyQLCLiq6EHwFZJfCSE9RqP6+0LY0DhTU Vl7xz+nBDxmKOsY7rwzc4+20+o5JEtB2zlBOTWJOxpbVy45z2/drRSMZzcumUd4Bxd0v+w wQYrI4hRt1lkANhIQSqVulm3Fp1QvV4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730820371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hWcndDAH9enw8rMuBtz8GGxG4LoX2GMqrDgIeyZxpJ4=; b=MO/Bs1O6ulEaN3qy0R0yacA8EbKi9CqxD/wGe9cZyoglnMQB3IDoqBp49Dce15isPZ53gX YQpION/AggyEfMCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7DDB11394A; Tue, 5 Nov 2024 15:26:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ewy9HRM5KmcJNAAAD6G6ig (envelope-from ); Tue, 05 Nov 2024 15:26:11 +0000 Date: Tue, 5 Nov 2024 16:26:15 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20241105-landlock_network-v2-0-d58791487919@suse.com> <20241105-landlock_network-v2-3-d58791487919@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241105-landlock_network-v2-3-d58791487919@suse.com> X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email, yuki.lan:mid, imap1.dmz-prg2.suse.org:helo] X-Virus-Scanned: clamav-milter 1.0.3 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 3/4] Add landlock08 test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +#include "landlock_common.h" > + > +#define ADDRESS_PORT 0x7c90 Hardcoding ports like this is frowned upon. We do have TST_GET_UNUSED_PORT() function so that we can get unused port (per family) in the test setup(). The rest of the code looks good to me. Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp