Re: [LTP] [PATCH v2 3/4] Add landlock08 test

Cyril Hrubis
2024-11-05T15:26:32Z

Hi!
> +#include "landlock_common.h"
> +
> +#define ADDRESS_PORT 0x7c90

Hardcoding ports like this is frowned upon. We do have
TST_GET_UNUSED_PORT() function so that we can get unused port (per
family) in the test setup().

The rest of the code looks good to me.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

--
Cyril Hrubis
chrubis@suse.cz