From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/4] Network helpers in landlock suite common functions
Date: Tue, 5 Nov 2024 16:27:59 +0100 [thread overview]
Message-ID: <Zyo5f7_Jx7nqGtBc@yuki.lan> (raw)
In-Reply-To: <20241105-landlock_network-v2-2-d58791487919@suse.com>
Hi!
> +#define IPV4_ADDRESS "127.0.0.1"
Maybe IPV4_LOCALHOST instead?
> +#define IPV6_ADDRESS "::1"
Here as well?
> +struct socket_data {
> + struct sockaddr_in addr_ipv4;
> + struct sockaddr_in6 addr_ipv6;
These two could be inside an anonymous union I suppose, but we hardly
optimize for size here.
> + size_t address_size;
Otherwise it looks good:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-11-05 15:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 9:34 [LTP] [PATCH v2 0/4] landlock network coverage support Andrea Cervesato
2024-11-05 9:34 ` [LTP] [PATCH v2 1/4] Fallback landlock network support Andrea Cervesato
2024-11-05 12:31 ` Li Wang
2024-11-05 12:42 ` Li Wang
2024-11-05 12:59 ` Andrea Cervesato via ltp
2024-11-05 13:15 ` Cyril Hrubis
2024-11-05 15:13 ` Cyril Hrubis
2024-11-06 7:13 ` Li Wang
2024-11-05 12:47 ` Andrea Cervesato via ltp
2024-11-05 13:08 ` Cyril Hrubis
2024-11-05 13:15 ` Andrea Cervesato via ltp
2024-11-05 9:34 ` [LTP] [PATCH v2 2/4] Network helpers in landlock suite common functions Andrea Cervesato
2024-11-05 15:27 ` Cyril Hrubis [this message]
2024-11-05 9:34 ` [LTP] [PATCH v2 3/4] Add landlock08 test Andrea Cervesato
2024-11-05 15:26 ` Cyril Hrubis
2024-11-05 9:34 ` [LTP] [PATCH v2 4/4] Add error coverage for landlock network support Andrea Cervesato
2024-11-05 15:39 ` Cyril Hrubis
2024-11-05 17:45 ` Cyril Hrubis
2024-11-06 10:29 ` Andrea Cervesato via ltp
2024-11-06 10:38 ` Cyril Hrubis
2024-11-06 11:01 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyo5f7_Jx7nqGtBc@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox