From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDAA8D2C139 for ; Tue, 5 Nov 2024 15:28:12 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 6E3D43D2790 for ; Tue, 5 Nov 2024 16:28:11 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 032443D26E8 for ; Tue, 5 Nov 2024 16:27:56 +0100 (CET) Authentication-Results: in-7.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.130; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id A1E582379A1 for ; Tue, 5 Nov 2024 16:27:55 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E7BA021CAD; Tue, 5 Nov 2024 15:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730820474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q2h4QhvsKieRRxcPmaUKgeADEsg6i2WjaJ1Kd6F9zvI=; b=GYLDSCYAFwtYSY/j8msacDmUSkCYFEOzOPDovyselQOn7f5NNnj4zYbAmMm/oBsOqBREdo sEieF4p18dF8+ORjjGTARmef5ThutqU5+H5RR8BQ1rC8uRnmLnm+LAiZ6k/FClONbwJs12 OFAhDf1jpagknk6GwsCeR3Eny1J2SG0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730820474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q2h4QhvsKieRRxcPmaUKgeADEsg6i2WjaJ1Kd6F9zvI=; b=WqM/ATl/TlrartkhGJXZ9CyvbVhXxQU/c2za4HTUg+8bvr6aI3suNZ4oP4hiHC93x4j5ms i5GCk54WsJSf1tBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730820474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q2h4QhvsKieRRxcPmaUKgeADEsg6i2WjaJ1Kd6F9zvI=; b=GYLDSCYAFwtYSY/j8msacDmUSkCYFEOzOPDovyselQOn7f5NNnj4zYbAmMm/oBsOqBREdo sEieF4p18dF8+ORjjGTARmef5ThutqU5+H5RR8BQ1rC8uRnmLnm+LAiZ6k/FClONbwJs12 OFAhDf1jpagknk6GwsCeR3Eny1J2SG0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730820474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q2h4QhvsKieRRxcPmaUKgeADEsg6i2WjaJ1Kd6F9zvI=; b=WqM/ATl/TlrartkhGJXZ9CyvbVhXxQU/c2za4HTUg+8bvr6aI3suNZ4oP4hiHC93x4j5ms i5GCk54WsJSf1tBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D95371394A; Tue, 5 Nov 2024 15:27:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id lcRBNHo5KmeiNAAAD6G6ig (envelope-from ); Tue, 05 Nov 2024 15:27:54 +0000 Date: Tue, 5 Nov 2024 16:27:59 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20241105-landlock_network-v2-0-d58791487919@suse.com> <20241105-landlock_network-v2-2-d58791487919@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241105-landlock_network-v2-2-d58791487919@suse.com> X-Spamd-Result: default: False [-8.30 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email, yuki.lan:mid, imap1.dmz-prg2.suse.org:helo] X-Virus-Scanned: clamav-milter 1.0.3 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 2/4] Network helpers in landlock suite common functions X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +#define IPV4_ADDRESS "127.0.0.1" Maybe IPV4_LOCALHOST instead? > +#define IPV6_ADDRESS "::1" Here as well? > +struct socket_data { > + struct sockaddr_in addr_ipv4; > + struct sockaddr_in6 addr_ipv6; These two could be inside an anonymous union I suppose, but we hardly optimize for size here. > + size_t address_size; Otherwise it looks good: Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp