public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Wei Gao via ltp <ltp@lists.linux.it>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] mq_timedreceive01: Fix different signedness error on 32bit
Date: Tue, 12 Nov 2024 20:37:22 -0500	[thread overview]
Message-ID: <ZzQC0vMtMaK0+nQU@wegao> (raw)
In-Reply-To: <20241112171831.156440-1-pvorel@suse.cz>

On Tue, Nov 12, 2024 at 06:18:30PM +0100, Petr Vorel wrote:
> warning: comparison of integer expressions of different signedness:
> ‘unsigned int’ and ‘long int’ [-Wsign-compare].
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c b/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> index 3870b4087a..d4f447d047 100644
> --- a/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> +++ b/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> @@ -183,7 +183,7 @@ static void do_test(unsigned int i)
>  		return;
>  	}
>  
> -	if (tc->len != TST_RET) {
> +	if ((long)tc->len != TST_RET) {
>  		tst_res(TFAIL, "mq_timedreceive() wrong length %ld, expected %u",
>  			TST_RET, tc->len);
>  		return;
Reviewed-by: Wei Gao <wegao@suse.com>
> -- 
> 2.47.0
> 

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-11-13  1:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 17:18 [LTP] [PATCH 1/2] mq_timedreceive01: Fix different signedness error on 32bit Petr Vorel
2024-11-12 17:18 ` [LTP] [PATCH 2/2] mq_timedreceive01: Workaround segfault on libc variant on 32 bit Petr Vorel
2024-11-13  3:00   ` Wei Gao via ltp
2024-11-14 14:53     ` Petr Vorel
2024-11-15 12:57       ` Jan Stancek
2024-11-26 14:31   ` Cyril Hrubis
2024-11-26 18:32     ` Petr Vorel
2024-11-13  1:37 ` Wei Gao via ltp [this message]
2024-11-26 14:29 ` [LTP] [PATCH 1/2] mq_timedreceive01: Fix different signedness error on 32bit Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzQC0vMtMaK0+nQU@wegao \
    --to=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox