From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: Dominique Leuenberger <dleuenberger@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] select03: Fix false positive on TCONF
Date: Wed, 13 Nov 2024 15:04:05 +0100 [thread overview]
Message-ID: <ZzSxqtWz-FxX8-NO@yuki.lan> (raw)
In-Reply-To: <79ac6cc7-33f7-4b24-ab00-8b396025d901@suse.cz>
Hi!
> As long as all errors are reported by the child through
> tst_res()/tst_brk(), we don't need to care about the exit code since
> it'll be recorded in the shared result buffer. I vote for removing the
> WEXITSTATUS() check and adding a comment above the condition that it's
> not needed.
I think that doing exit(TTYPE_RESULT(type)) in the tst_vbrk_() for the
child processes was a mistake that needs to be corrected either way. I
will send a patch for the test library to finally fix that and then
there will be no cases where the child exits with anything but 0.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-11-13 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 10:59 [LTP] [PATCH 1/1] select03: Fix false positive on TCONF Petr Vorel
2024-11-13 11:29 ` Wei Gao via ltp
2024-11-13 11:29 ` Avinesh Kumar
2024-11-13 13:39 ` Cyril Hrubis
2024-11-13 14:07 ` Petr Vorel
2024-11-13 14:20 ` Cyril Hrubis
2024-11-13 15:17 ` Petr Vorel
2024-11-14 11:18 ` Petr Vorel
2024-11-13 13:46 ` Martin Doucha
2024-11-13 14:04 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzSxqtWz-FxX8-NO@yuki.lan \
--to=chrubis@suse.cz \
--cc=dleuenberger@suse.com \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox