Re: [LTP] [PATCH v2 02/13] lib: Replace path_exist() with tst_path_exists()

[pvorel <pvorel@suse.de>]

On 2025-02-10 14:07, Cyril Hrubis wrote:
> Hi!
>> > Move and rename the path_exist() function from
>> > testcases/kernel/mem/lib/ to the to level library.
>> >
>> > This removes mem.h dependency from mem/cpuset/ test.
>> >
>> > Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
>> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
>> > ---
>> >  include/tst_fs.h                       | 10 ++++++++++
>> >  lib/tst_path_exists.c                  | 23 +++++++++++++++++++++++
>> 
>> The only thing I don't like is creating file for single functions.
>> My long term plan was to have fewer files with more functions.
>> I'm sorry I did not point this out in v1, thus feel free to ignore it.
> 
> Feel free to move this code to a file you find appropriate and merge 
> the
> patchset.

Cyril, please merge it as is.
After that, I send a patch for

Moving into newly created tst_fs.c these new API sources: tst_ioctl.c, 
tst_fs_setup.c, tst_fill_fs.c, tst_fill_file.c, tst_path_exists.c, 
tst_supported_fs_types.c.

And moving into newly created tst_fs_old.c these old API sources:
tst_fs_has_free.c (only dma_thread_diotest.c has not been converted into 
new API), tst_fs_type.c.

Having everything eventually in single tst_fs.c might be too much, but 
I'm not sure if it's worth to spent time to split tst_fs.h into separate 
headers (and then to corresponding c sources).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp