public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Joerg Vehlow <lkml@jv-coder.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/1] fs_bind: Convert to ltp tests
Date: Tue, 6 Jul 2021 11:59:17 +0200	[thread overview]
Message-ID: <a4595bcc-15e5-e79a-bd95-143630a33774@jv-coder.de> (raw)
In-Reply-To: <87wnq37p2j.fsf@suse.de>

Hi Richard,

On 7/6/2021 11:45 AM, Richard Palethorpe wrote:
> Hello Joerg,
>
> Joerg Vehlow <lkml@jv-coder.de> writes:
>
>> Hi everyone,
>>
>> I know this is a huge changeset, but there is not really a good way to
>> break it down into multiple commits. Every step in between would either
>> lead to a broken test suite or a change, that is then changed again.
>> So I made this one huge commit, that converts all of the tests of the
>> testsuite in one go.
> It seems like there are no file renames (according to Git), but many
> files are deleted and created. So you could split the commit into a
> deletion patch and a creation patch.
>
> I guess the deletion patch might have to remove some runtest file
> entries temporarily? However I don't see a big problem with that.
Actually most deletions are renames, that git just did not pick up, 
because of the immense
changes in the tests.
I could add two patches:
1. rename (And delete old testrunner stuff and runtest entries)
2. Apply all changes

This should allow better review of the actual changes, at least for most 
tests.

J?rg

  reply	other threads:[~2021-07-06  9:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 13:50 [LTP] [PATCH 0/1] fs_bind: Convert to ltp tests Joerg Vehlow
2021-07-05 13:50 ` [LTP] [PATCH] " Joerg Vehlow
2021-07-06  9:41   ` Richard Palethorpe
2021-07-06  9:57     ` Joerg Vehlow
2021-07-06  9:45 ` [LTP] [PATCH 0/1] " Richard Palethorpe
2021-07-06  9:59   ` Joerg Vehlow [this message]
2021-07-06 10:36     ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4595bcc-15e5-e79a-bd95-143630a33774@jv-coder.de \
    --to=lkml@jv-coder.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox