From: Jia Zhang <zhang.jia@linux.alibaba.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 6/6] ima/ima_violations: Temporarily remove the printk rate limit
Date: Wed, 16 Jan 2019 10:53:19 +0800 [thread overview]
Message-ID: <a4c87b61-33a4-cc8b-489e-023c74bfcc48@linux.alibaba.com> (raw)
In-Reply-To: <20190115172401.GC2954@dell5510>
On 2019/1/16 上午1:24, Petr Vorel wrote:
> Hi Jia,
>
>>>> + reset_printk_ratelimit
>>> This should be called in cleanup function.
>>> Actually as it's called only once I'd put it into cleanup function.
>
>> I recognized that ima_setup.sh already defines a cleanup() so I cannot
>> define another cleanup function in ima_violations.sh. Do you mean moving
>> reset_printk_ratelimit into cleanup() defined in ima_setup.sh?
> No. You can define redefine local cleanup function in ima_violations.sh after
> loading ima_setup.sh and call ima_cleanup() in it.
>
> + you can change setup in ima_setup.sh:
> TST_CLEANUP="${TST_CLEANUP:-ima_cleanup}"
> (see testcases/network/stress/ipsec/ipsec_lib.sh and testcases/network/stress/ipsec/ipsec_lib.sh and it's usage).
>
> Cleanup of something defined in setup should be always in cleanup function and
> not in any tests as it's called always after tst_brk() calls (some tests might
> get skipped, so cleanup cannot be in them).
Thanks for the comments. I will send V3 to address this.
Jia
>
> Kind regards,
> Petr
>
next prev parent reply other threads:[~2019-01-16 2:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 2:14 [LTP] [PATCH v2 0/6] LTP IMA fix bundle Jia Zhang
2019-01-15 2:14 ` [LTP] [PATCH 1/6] ima/ima_boot_aggregate: Fix the definition of event log Jia Zhang
2019-01-15 2:14 ` [LTP] [PATCH 2/6] ima/ima_boot_aggregate: Don't hard code the length of sha1 hash Jia Zhang
2019-01-15 2:14 ` [LTP] [PATCH 3/6] ima/ima_boot_aggregate: Fix extending PCRs beyond PCR 0-7 Jia Zhang
2019-01-15 2:14 ` [LTP] [PATCH 4/6] ima: Code cleanup Jia Zhang
2019-01-15 2:14 ` [LTP] [PATCH 5/6] ima: Rename the folder name for policy files to datafiles Jia Zhang
2019-01-15 2:14 ` [LTP] [PATCH 6/6] ima/ima_violations: Temporarily remove the printk rate limit Jia Zhang
2019-01-15 15:07 ` Petr Vorel
2019-01-15 16:42 ` Jia Zhang
2019-01-15 17:24 ` Petr Vorel
2019-01-16 2:53 ` Jia Zhang [this message]
2019-01-15 18:34 ` [LTP] [PATCH v2 0/6] LTP IMA fix bundle Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4c87b61-33a4-cc8b-489e-023c74bfcc48@linux.alibaba.com \
--to=zhang.jia@linux.alibaba.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox