Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 4/5] shell lib: Add basic support for test cleanup
Date: Wed, 30 Apr 2025 10:57:29 +0200	[thread overview]
Message-ID: <aBHl-Rqg1QFe8tjw@yuki.lan> (raw)
In-Reply-To: <aBHkswcLfiC7sXSz@yuki.lan>

Hi!
And one possible solution is to source the environment first and the
loader last, on the top of your shell-loader-setup-cleanup.v2 branch:

diff --git a/testcases/lib/tests/shell_loader.sh b/testcases/lib/tests/shell_loader.sh
index eeed122c1..01acf6d35 100755
--- a/testcases/lib/tests/shell_loader.sh
+++ b/testcases/lib/tests/shell_loader.sh
@@ -14,6 +14,8 @@
 # }
 # ---

+. tst_env.sh
+
 tst_test()
 {
        tst_res TPASS "Shell loader works fine!"
diff --git a/testcases/lib/tst_env.sh b/testcases/lib/tst_env.sh
index 68f9a0daa..585790a7d 100644
--- a/testcases/lib/tst_env.sh
+++ b/testcases/lib/tst_env.sh
@@ -18,11 +18,6 @@ if [ -z "$LINENO" ]; then
        LINENO=-1
 fi

-if [ -z "$LTP_IPC_PATH" ]; then
-       echo "This script has to be executed from a LTP loader!"
-       exit 1
-fi
-
 tst_brk_()
 {
        tst_res_ "$@"


-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-04-30  8:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 17:24 [LTP] [RFC PATCH 0/5] shell loader rewrite to support TST_SETUP Petr Vorel
2025-02-28 17:24 ` [LTP] [RFC PATCH 1/5] shell lib: Add support for test cleanup Petr Vorel
2025-03-04 12:57   ` Li Wang
2025-03-04 13:08     ` Petr Vorel
2025-03-04 13:15       ` Li Wang
2025-02-28 17:24 ` [LTP] [RFC PATCH 2/5] lib: Allow test to have positional args Petr Vorel
2025-02-28 17:43   ` Petr Vorel
2025-03-07 16:17   ` Cyril Hrubis
2025-03-10 10:23     ` Petr Vorel
2025-03-07 16:27   ` Cyril Hrubis
2025-03-10 10:16     ` Petr Vorel
2025-02-28 17:24 ` [LTP] [RFC PATCH 3/5] shell: Move shell code into functions Petr Vorel
2025-02-28 17:45   ` Petr Vorel
2025-02-28 17:24 ` [LTP] [RFC PATCH 4/5] shell lib: Add basic support for test cleanup Petr Vorel
2025-03-07 16:40   ` Cyril Hrubis
2025-03-10 10:27     ` Petr Vorel
2025-04-25 18:33     ` Petr Vorel
2025-04-30  8:52       ` Cyril Hrubis
2025-04-30  8:57         ` Cyril Hrubis [this message]
2025-04-30 11:47           ` Petr Vorel
2025-04-30 13:39             ` Cyril Hrubis
2025-02-28 17:24 ` [LTP] [RFC PATCH 5/5] shell: Add shell_loader_setup_cleanup.sh test Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBHl-Rqg1QFe8tjw@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox