From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 0/4] shell loader rewrite to support TST_SETUP
Date: Fri, 2 May 2025 10:51:46 +0200 [thread overview]
Message-ID: <aBSHoimhpmTj1l_A@yuki.lan> (raw)
In-Reply-To: <20250430130417.43523-1-pvorel@suse.cz>
Hi!
> we are getting there, but not yet finished.
>
> one remaining problem - it requires *full* path in PATH. I wonder what
> basic I'm missing. The current change requires to use full path
> otherwise execvpe() fails.
>
> I suppose it is due change cwd due creating temporary directory - it
> fails only with:
> "needs_tmpdir": true
> shell_loader_setup_cleanup.sh does not suffer this problem.
> It's also not dash related, problem is on bash as well.
That is exactly it. The test cannot run scripts that it cannot find so
we need an absolute path to the directory the scripts are in. If you
look at run_tests.sh we do srcdir=$(realpath $(dirname $0)) and prefix
all the paths with that directory.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-05-02 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 13:04 [LTP] [PATCH v2 0/4] shell loader rewrite to support TST_SETUP Petr Vorel
2025-04-30 13:04 ` [LTP] [PATCH v2 1/4] shell lib: Add support for test cleanup Petr Vorel
2025-04-30 13:04 ` [LTP] [PATCH v2 2/4] shell: Move shell code into functions Petr Vorel
2025-05-02 9:26 ` Cyril Hrubis
2025-04-30 13:04 ` [LTP] [PATCH v2 3/4] shell lib: Add basic support for test setup Petr Vorel
2025-05-02 9:36 ` Cyril Hrubis
2025-04-30 13:04 ` [LTP] [PATCH v2 4/4] shell: Add shell_loader_setup_cleanup.sh test Petr Vorel
2025-05-02 8:51 ` Cyril Hrubis [this message]
2025-05-06 22:04 ` [LTP] [PATCH v2 0/4] shell loader rewrite to support TST_SETUP Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBSHoimhpmTj1l_A@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox