From: Cyril Hrubis <chrubis@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] mmap22.c: Test for new MAP_DROPPABLE flag for mmap
Date: Wed, 7 May 2025 17:25:38 +0200 [thread overview]
Message-ID: <aBt7ck35Dq8GIKHc@yuki.lan> (raw)
In-Reply-To: <20250428160421.3457215-1-wegao@suse.com>
Hi!
Pushed with a minor change, thanks.
We should check if the addr is valid before we attemp to unmap it in the
setup() so I've added:
diff --git a/testcases/kernel/syscalls/mmap/mmap22.c b/testcases/kernel/syscalls/mmap/mmap22.c
index bfef559e4..0e589dfab 100644
--- a/testcases/kernel/syscalls/mmap/mmap22.c
+++ b/testcases/kernel/syscalls/mmap/mmap22.c
@@ -72,8 +72,13 @@ static void setup(void)
{
void *addr = mmap(0, 1, PROT_READ | PROT_WRITE,
MAP_ANONYMOUS | MAP_DROPPABLE, -1, 0);
+
if (addr == MAP_FAILED && errno == EINVAL)
- tst_brk(TCONF, "MAP_DROPPABLE not support");
+ tst_brk(TCONF, "MAP_DROPPABLE not supported");
+
+ if (addr == MAP_FAILED)
+ tst_brk(TBROK | TERRNO, "mmap() MAP_DROPPABLE failed");
+
SAFE_MUNMAP(addr, 1);
}
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-05-07 15:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-28 13:32 [LTP] [PATCH v1] mmap21.c: Test for new MAP_DROPPABLE flag for mmap Wei Gao via ltp
2024-12-31 10:04 ` Li Wang
2025-01-02 9:38 ` Cyril Hrubis
2025-01-03 1:42 ` Wei Gao via ltp
2025-01-03 13:54 ` Wei Gao via ltp
2025-01-03 13:56 ` [LTP] [PATCH v2] " Wei Gao via ltp
2025-03-10 16:18 ` Cyril Hrubis
2025-04-16 19:16 ` [LTP] [PATCH v3] mmap22.c: " Wei Gao via ltp
2025-04-25 11:40 ` Cyril Hrubis
2025-04-28 16:04 ` [LTP] [PATCH v4] " Wei Gao via ltp
2025-05-07 15:25 ` Cyril Hrubis [this message]
2025-05-12 8:43 ` Jan Stancek via ltp
2025-05-13 15:44 ` Wei Gao via ltp
2025-05-14 8:51 ` Jan Stancek via ltp
2025-05-14 9:04 ` Li Wang via ltp
2025-05-14 9:10 ` Jan Stancek via ltp
2025-05-14 9:14 ` Li Wang via ltp
2025-05-14 11:15 ` Jan Stancek via ltp
2025-05-14 12:44 ` Li Wang via ltp
2025-05-14 12:54 ` Jan Stancek via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBt7ck35Dq8GIKHc@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox