Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 0/3] checkpoint: Refactor and unify shell/C reinit support
Date: Fri, 27 Jun 2025 12:43:42 +0200	[thread overview]
Message-ID: <aF513oTFTybxPdys@yuki.lan> (raw)
In-Reply-To: <CAEemH2fYij1tO0Yfb=pcqc0h_XfP4OonR4dO7PcviGP_vkxf3w@mail.gmail.com>

Hi!
> > > So, will you send a new patch (or I do that in my next version)?
> >
> > I will send the patchset.
> >
> 
> Thanks! And one more question:
> 
> The tst_checkpoint_init() in tst_checkpoint.c is not used by any test
> and library, should we delete it (and declare that the IPC only init/reinit
> by the tst_test.c function)?

There is actually a define to TST_CHECKPOINT_INIT in the
include/old/old_checkpoint.h but it looks like the last parts where this
is called are old library tests that should be removed along with that.

And the last test that was using it before rewrite was:

commit b043751a6984c41db61067eebb0fee6ebf303960
Author: Andrea Cervesato <andrea.cervesato@suse.de>
Date:   Fri Mar 25 13:54:43 2022 +0100

    Rewrite shm_comm.c using new LTP API

    Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.de>
    Reviewed-by: Cyril Hrubis <chrubis@suse.cz>


So yes please, let's get rid of it. We should have do so actually three
years ago.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-06-27 10:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 10:26 [LTP] [PATCH 0/3] checkpoint: Refactor and unify shell/C reinit support Li Wang via ltp
2025-06-16 10:26 ` [LTP] [PATCH 1/3] shell/lib: refactor checkpoint with shared path for exec() support Li Wang via ltp
2025-06-17 12:18   ` Avinesh Kumar
2025-06-16 10:26 ` [LTP] [PATCH 2/3] kernel/pec: switch to new checkpoint wait/wake interface Li Wang via ltp
2025-06-16 10:26 ` [LTP] [PATCH 3/3] tst_checkpoint: Detect and reinit shell or C style checkpoint file Li Wang via ltp
2025-06-26 13:26 ` [LTP] [PATCH 0/3] checkpoint: Refactor and unify shell/C reinit support Cyril Hrubis
2025-06-26 15:09   ` Li Wang via ltp
2025-06-27  7:49     ` Cyril Hrubis
2025-06-27  9:25       ` Li Wang via ltp
2025-06-27 10:20         ` Cyril Hrubis
2025-06-27 10:28           ` Li Wang via ltp
2025-06-27 10:43             ` Cyril Hrubis [this message]
2025-06-27 10:49               ` Li Wang via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aF513oTFTybxPdys@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox