From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 4/6] Add ioctl_pidfd02 test
Date: Fri, 27 Jun 2025 11:47:25 +0200 [thread overview]
Message-ID: <aF5orcIPzGviYyj6@yuki.lan> (raw)
In-Reply-To: <aF5gXnHipDoPXla6@yuki.lan>
Hi!
> > + TST_EXP_EQ_LI(info->mask & PIDFD_INFO_EXIT, PIDFD_INFO_EXIT);
> > + TST_EXP_EQ_LI(WIFEXITED(info->exit_code), WIFEXITED(status));
> > + TST_EXP_EQ_LI(WEXITSTATUS(info->exit_code), WEXITSTATUS(status));
>
> And here we should check that we got the same fields set as in the
> previous case when the process was still running plus the exit_code.
>
> I suppose that we will need two info structures so that we can do the
> comparsion. Also it wouldn't harm to clear the structures with memset
> before use.
Ah no, if task has been reaped only exit value is available. So in the
latter case only the PIDFD_INFO_EXIT should be set in flags.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-06-27 9:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 12:34 [LTP] [PATCH 0/6] ioctl_pidfd testing suite Andrea Cervesato
2025-06-26 12:34 ` [LTP] [PATCH 1/6] Provide pidfd parameter in tst_clone_args Andrea Cervesato
2025-06-26 12:34 ` [LTP] [PATCH 2/6] Fallback PIDFD_GET_INFO related definitions Andrea Cervesato
2025-06-26 12:34 ` [LTP] [PATCH 3/6] Add ioctl_pidfd01 test Andrea Cervesato
2025-06-26 12:34 ` [LTP] [PATCH 4/6] Add ioctl_pidfd02 test Andrea Cervesato
2025-06-27 9:11 ` Cyril Hrubis
2025-06-27 9:47 ` Cyril Hrubis [this message]
2025-06-27 9:53 ` Cyril Hrubis
2025-06-26 12:34 ` [LTP] [PATCH 5/6] Add ioctl_pidfd03 test Andrea Cervesato
2025-06-27 9:56 ` Cyril Hrubis
2025-06-30 12:50 ` Andrea Cervesato via ltp
2025-06-30 14:30 ` Cyril Hrubis
2025-06-26 12:34 ` [LTP] [PATCH 6/6] Add ioctl_pidfd04 test Andrea Cervesato
2025-06-27 10:14 ` [LTP] [PATCH 0/6] ioctl_pidfd testing suite Cyril Hrubis
2025-07-01 11:15 ` Andrea Cervesato via ltp
2025-07-01 11:40 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF5orcIPzGviYyj6@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox