From: Cyril Hrubis <chrubis@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] mount08.c: SKIP test if selinux is running
Date: Mon, 28 Jul 2025 12:04:09 +0200 [thread overview]
Message-ID: <aIdLGf5Kx5NuAH98@yuki.lan> (raw)
In-Reply-To: <20250728212752.774436-1-wegao@suse.com>
The commit is missing why this has to be done. Please be more verbose
and explain the reasons in the commit message.
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
> testcases/kernel/syscalls/mount/mount08.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/mount/mount08.c b/testcases/kernel/syscalls/mount/mount08.c
> index e2824ac55..1f97de182 100644
> --- a/testcases/kernel/syscalls/mount/mount08.c
> +++ b/testcases/kernel/syscalls/mount/mount08.c
> @@ -41,6 +41,9 @@ static void run(void)
>
> static void setup(void)
> {
> + if (tst_selinux_enforcing())
> + tst_brk(TCONF, "SKIP test since selinux is running");
> +
> SAFE_TOUCH(FOO, 0777, NULL);
> SAFE_TOUCH(BAR, 0777, NULL);
> }
> --
> 2.49.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-07-28 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 21:27 [LTP] [PATCH v1] mount08.c: SKIP test if selinux is running Wei Gao via ltp
2025-07-28 10:04 ` Cyril Hrubis [this message]
2025-07-28 10:31 ` Petr Vorel
2025-07-31 14:33 ` [LTP] [PATCH v2] mount08.c: Check EACCES error when test under selinux enabled in enforce mode Wei Gao via ltp
2025-07-31 4:39 ` Petr Vorel
2025-07-31 6:44 ` Andrea Cervesato via ltp
2025-07-31 10:54 ` Petr Vorel
2025-08-01 0:28 ` [LTP] [PATCH v3] " Wei Gao via ltp
2025-07-31 17:09 ` Andrea Cervesato via ltp
2025-07-31 17:13 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIdLGf5Kx5NuAH98@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox