From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/1] Makefile: Add kernel modules related make targets
Date: Wed, 6 Aug 2025 15:29:33 +0200 [thread overview]
Message-ID: <aJNYvU7O9qKCI1tU@yuki.lan> (raw)
In-Reply-To: <20250806115217.GB431066@pevik>
Hi!
> MODULE_DIRS := $(shell \
> dirname $(grep -l 'include.*module\.mk' $(find testcases/ -type f -name 'Makefile')) | sort -u
> )
>
> Although this works, I wonder if we want to depend on a shell detection like
> this (I'd appreciate others' opinion).
Looks okay to me. It's much better than hardcoding the paths, we will
likely forget to update any hardcoded info.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-08-06 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 10:09 [LTP] [PATCH v2 1/1] Makefile: Add kernel modules related make targets Petr Vorel
2025-08-01 10:20 ` Petr Vorel
2025-08-02 3:59 ` Li Wang via ltp
2025-08-06 11:47 ` Petr Vorel
2025-08-02 3:25 ` Li Wang via ltp
2025-08-02 4:11 ` Li Wang via ltp
2025-08-06 11:52 ` Petr Vorel
2025-08-06 13:29 ` Cyril Hrubis [this message]
2025-08-06 19:49 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJNYvU7O9qKCI1tU@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox