Re: [LTP] [PATCH] tst_umount: Retry open() after umount to handle delayed device release

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> --- a/lib/tst_mkfs.c
> +++ b/lib/tst_mkfs.c
> @@ -107,6 +107,13 @@ void tst_mkfs_(const char *file, const int lineno,
> void (cleanup_fn)(void),
>                         "%s not found in $PATH", mkfs);
>         break;
>         default:
> +               tst_resm_(file, lineno, TINFO,
> +                       "Check if mkfs failed with the (loop) device busy. "
> +                       "Background probing (e.g., udisks2) can cause this.
> \n"
> +                       "Consider temporarily stopping udisks2 during the
> test:\n"
> +                       "  systemctl stop udisks2.service\n"
> +                       "and restart afterward:\n"
> +                       "  systemctl start udisks2.service");

I wouldn't include the systemctl commands in the message, anybody who is
using LTP to test the system should know how to start and stop system
daemons. Let's keep the message short and to the point.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp