From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: Move tst_get_supported_fs_types() to private header
Date: Fri, 29 Aug 2025 15:15:28 +0200 [thread overview]
Message-ID: <aLGn8AxqpNyL8MSD@yuki.lan> (raw)
In-Reply-To: <20250602150647.GA331929@pevik>
Hi!
> > +/*
> > + * Returns NULL-terminated array of kernel-supported filesystems.
> > + *
> > + * @skiplist A NULL terminated array of filesystems to skip.
> > + */
> > +const char **tst_get_supported_fs_types(const char *const *skiplist);
>
> BTW I suppose as a "private" header is not supposed to be used in in test programs
> we don't want to use kerneldoc, right?
Do we? There should be some kind of documentation even for internal
functions and I do not see a reson to use a different format. Having
kerneldoc vs doxygen is confusing enough for me adding third format
wouldn't help.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2025-08-29 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 11:47 [LTP] [PATCH] lib: Move tst_get_supported_fs_types() to private header Cyril Hrubis
2025-05-28 5:08 ` Li Wang via ltp
2025-08-29 13:15 ` Cyril Hrubis
2025-06-02 15:06 ` Petr Vorel
2025-08-29 13:15 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLGn8AxqpNyL8MSD@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox