[LTP] [PATCH v1] ioctl_loop01.c: Use proper device for partitioning

[LTP] [PATCH v1] ioctl_loop01.c: Use proper device for partitioning

[Wei Gao via ltp]

This is same patch used on ioctl09,the page cache of loop0 can cache old
version of the partition table which is then used by the partitioning
code. Fix the problem by calling parted against the loop device directly.

Link: https://lore.kernel.org/ltp/20250829141932.31997-1-jack@suse.cz/
Signed-off-by: Wei Gao <wegao@suse.com>
---
 testcases/kernel/syscalls/ioctl/ioctl_loop01.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
index c9137bf1e..5ee7a474a 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
@@ -98,7 +98,7 @@ static void verify_ioctl_loop(void)
 static void setup(void)
 {
 	int ret;
-	const char *const cmd_parted[] = {"parted", "-s", "test.img", "mklabel", "msdos", "mkpart",
+	const char *const cmd_parted[] = {"parted", "-s", dev_path, "mklabel", "msdos", "mkpart",
 	                                  "primary", "ext4", "1M", "10M", NULL};
 
 	dev_num = tst_find_free_loopdev(dev_path, sizeof(dev_path));
-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] ioctl_loop01.c: Use proper device for partitioning

[Petr Vorel]

Hi Wei,

> This is same patch used on ioctl09,the page cache of loop0 can cache old
> version of the partition table which is then used by the partitioning
> code. Fix the problem by calling parted against the loop device directly.

> Link: https://lore.kernel.org/ltp/20250829141932.31997-1-jack@suse.cz/
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
>  testcases/kernel/syscalls/ioctl/ioctl_loop01.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> index c9137bf1e..5ee7a474a 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> +++ b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> @@ -98,7 +98,7 @@ static void verify_ioctl_loop(void)
>  static void setup(void)
>  {
>  	int ret;
> -	const char *const cmd_parted[] = {"parted", "-s", "test.img", "mklabel", "msdos", "mkpart",
> +	const char *const cmd_parted[] = {"parted", "-s", dev_path, "mklabel", "msdos", "mkpart",
>  	                                  "primary", "ext4", "1M", "10M", NULL};

Indeed I was able to trigger the same error:

[ 2642.979234] ioctl_loop01
[ 2642.997424] loop8: detected capacity change from 0 to 20480
[ 2643.015094]  loop8: p1
[ 2643.040903] blk_update_request: I/O error, dev loop8, sector 20352 op 0x0:(READ) flags 0x80700 phys_seg 1 prio class 0
[ 2643.042105] blk_update_request: I/O error, dev loop8, sector 20352 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
[ 2643.043361] Buffer I/O error on dev loop8p1, logical block 2288, async page read
[ 2643.044539] __loop_clr_fd: partition scan of loop8 failed (rc=-16)
[ 2643.097517] blk_update_request: I/O error, dev loop8, sector 20352 op 0x0:(READ) flags 0x80700 phys_seg 1 prio class 0
[ 2643.098175] blk_update_request: I/O error, dev loop8, sector 20352 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
[ 2643.098767] Buffer I/O error on dev loop8p1, logical block 2288, async page read
[ 2643.109133] ioctl_ficlone02
[ 2643.109824] loop8: detected capacity change from 0 to 614400
[ 2643.175605] /dev/zero: Can't open blockdev
[ 2643.307531] EXT4-fs (loop8): mounting ext2 file system using the ext4 subsystem
[ 2643.312401] EXT4-fs (loop8): mounted filesystem without journal. Opts: (null). Quota mode: none.
[ 2643.471527] EXT4-fs (loop8): mounting ext3 file system using the ext4 subsystem
[ 2643.476826] EXT4-fs (loop8): mounted filesystem with ordered data mode. Opts: (null). Quota mode: none.
[ 2643.644734] EXT4-fs (loop8): mounted filesystem with ordered data mode. Opts: (null). Quota mode: none.

But you change introduces one TCONF:

--- old	2025-09-01 05:05:50.401105483 -0400
+++ new	2025-09-01 05:05:01.925105483 -0400
@@ -5,6 +5,7 @@
 tst_kconfig.c:678: TINFO: CONFIG_FAULT_INJECTION kernel option detected which might slow the execution
 tst_test.c:1827: TINFO: Overall timeout per run is 0h 02m 04s
 tst_device.c:99: TINFO: Found free device 6 '/dev/loop6'
+ioctl_loop01.c:119: TCONF: parted exited with 1
 tst_buffers.c:57: TINFO: Test is using guarded buffers
 ioctl_loop01.c:84: TPASS: /sys/block/loop6/loop/partscan = 0
 ioctl_loop01.c:85: TPASS: /sys/block/loop6/loop/autoclear = 0
@@ -12,18 +13,16 @@
 ioctl_loop01.c:56: TPASS: get expected lo_flag 12
 ioctl_loop01.c:58: TPASS: /sys/block/loop6/loop/partscan = 1
 ioctl_loop01.c:59: TPASS: /sys/block/loop6/loop/autoclear = 1
-ioctl_loop01.c:68: TPASS: access /dev/loop6p1 succeeds
-ioctl_loop01.c:74: TPASS: access /sys/block/loop6/loop6p1 succeeds
+ioctl_loop01.c:62: TINFO: Current environment doesn't have parted disk, skip it
 ioctl_loop01.c:90: TINFO: Test flag can be clear
 ioctl_loop01.c:56: TPASS: get expected lo_flag 8
 ioctl_loop01.c:58: TPASS: /sys/block/loop6/loop/partscan = 1
 ioctl_loop01.c:59: TPASS: /sys/block/loop6/loop/autoclear = 0
-ioctl_loop01.c:68: TPASS: access /dev/loop6p1 succeeds
-ioctl_loop01.c:74: TPASS: access /sys/block/loop6/loop6p1 succeeds
+ioctl_loop01.c:62: TINFO: Current environment doesn't have parted disk, skip it
 
 Summary:
-passed   13
+passed   9
 failed   0
 broken   0
-skipped  0
+skipped  1
 warnings 0

That means your change effectively disable that code. => NACK

in ioctl09.c uses the first command with "test.img", then loop device on the
second run.

Surprisingly trying to attach helps 'parted' to use it, although it produces a
warning:

+++ testcases/kernel/syscalls/ioctl/ioctl_loop01.c
@@ -106,6 +106,7 @@ static void setup(void)
                tst_brk(TBROK, "Failed to find free loop device");

        tst_fill_file("test.img", 0, 1024 * 1024, 10);
+       tst_attach_device(dev_path, "test.img");

        ret = tst_cmd(cmd_parted, NULL, NULL, TST_CMD_PASS_RETVAL);
        switch (ret) {

tst_device.c:99: TINFO: Found free device 9 '/dev/loop9'
tst_buffers.c:57: TINFO: Test is using guarded buffers
tst_device.c:176: TWARN: ioctl(/dev/loop9, LOOP_SET_FD, test.img) failed: EBUSY (16)
ioctl_loop01.c:84: TPASS: /sys/block/loop9/loop/partscan = 0
ioctl_loop01.c:85: TPASS: /sys/block/loop9/loop/autoclear = 0
ioctl_loop01.c:86: TPASS: /sys/block/loop9/loop/backing_file = '/tmp/LTP_iocfMLSpX/test.img'
ioctl_loop01.c:56: TPASS: get expected lo_flag 12
ioctl_loop01.c:58: TPASS: /sys/block/loop9/loop/partscan = 1
ioctl_loop01.c:59: TPASS: /sys/block/loop9/loop/autoclear = 1
ioctl_loop01.c:68: TPASS: access /dev/loop9p1 succeeds
ioctl_loop01.c:74: TPASS: access /sys/block/loop9/loop9p1 succeeds
ioctl_loop01.c:90: TINFO: Test flag can be clear
ioctl_loop01.c:56: TPASS: get expected lo_flag 8
ioctl_loop01.c:58: TPASS: /sys/block/loop9/loop/partscan = 1
ioctl_loop01.c:59: TPASS: /sys/block/loop9/loop/autoclear = 0
ioctl_loop01.c:68: TPASS: access /dev/loop9p1 succeeds
ioctl_loop01.c:74: TPASS: access /sys/block/loop9/loop9p1 succeeds

Of course TWARN is also no-go.
@Jan @Cyril @Li Any hint what am I missing.

Besides missing there is missing TST_CMD_TCONF_ON_MISSING on the flags (see
today's fix [1]), but that's minor.

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/commit/9691c4b2bea4f772d61ca9e9a93d2087c88f6040

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] ioctl_loop01.c: Use proper device for partitioning

[Wei Gao via ltp]

On Mon, Sep 01, 2025 at 12:38:05PM +0200, Petr Vorel wrote:
> Hi Wei,
> 
> > This is same patch used on ioctl09,the page cache of loop0 can cache old
> > version of the partition table which is then used by the partitioning
> > code. Fix the problem by calling parted against the loop device directly.
> 
> > Link: https://lore.kernel.org/ltp/20250829141932.31997-1-jack@suse.cz/
> > Signed-off-by: Wei Gao <wegao@suse.com>
> > ---
> >  testcases/kernel/syscalls/ioctl/ioctl_loop01.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> > diff --git a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> > index c9137bf1e..5ee7a474a 100644
> > --- a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> > +++ b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> > @@ -98,7 +98,7 @@ static void verify_ioctl_loop(void)
> >  static void setup(void)
> >  {
> >  	int ret;
> > -	const char *const cmd_parted[] = {"parted", "-s", "test.img", "mklabel", "msdos", "mkpart",
> > +	const char *const cmd_parted[] = {"parted", "-s", dev_path, "mklabel", "msdos", "mkpart",
> >  	                                  "primary", "ext4", "1M", "10M", NULL};
> 
> Indeed I was able to trigger the same error:
> 
> [ 2642.979234] ioctl_loop01
> [ 2642.997424] loop8: detected capacity change from 0 to 20480
> [ 2643.015094]  loop8: p1
> [ 2643.040903] blk_update_request: I/O error, dev loop8, sector 20352 op 0x0:(READ) flags 0x80700 phys_seg 1 prio class 0
> [ 2643.042105] blk_update_request: I/O error, dev loop8, sector 20352 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
> [ 2643.043361] Buffer I/O error on dev loop8p1, logical block 2288, async page read
> [ 2643.044539] __loop_clr_fd: partition scan of loop8 failed (rc=-16)
> [ 2643.097517] blk_update_request: I/O error, dev loop8, sector 20352 op 0x0:(READ) flags 0x80700 phys_seg 1 prio class 0
> [ 2643.098175] blk_update_request: I/O error, dev loop8, sector 20352 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
> [ 2643.098767] Buffer I/O error on dev loop8p1, logical block 2288, async page read
> [ 2643.109133] ioctl_ficlone02
> [ 2643.109824] loop8: detected capacity change from 0 to 614400
> [ 2643.175605] /dev/zero: Can't open blockdev
> [ 2643.307531] EXT4-fs (loop8): mounting ext2 file system using the ext4 subsystem
> [ 2643.312401] EXT4-fs (loop8): mounted filesystem without journal. Opts: (null). Quota mode: none.
> [ 2643.471527] EXT4-fs (loop8): mounting ext3 file system using the ext4 subsystem
> [ 2643.476826] EXT4-fs (loop8): mounted filesystem with ordered data mode. Opts: (null). Quota mode: none.
> [ 2643.644734] EXT4-fs (loop8): mounted filesystem with ordered data mode. Opts: (null). Quota mode: none.
> 
> But you change introduces one TCONF:
> 
> --- old	2025-09-01 05:05:50.401105483 -0400
> +++ new	2025-09-01 05:05:01.925105483 -0400
> @@ -5,6 +5,7 @@
>  tst_kconfig.c:678: TINFO: CONFIG_FAULT_INJECTION kernel option detected which might slow the execution
>  tst_test.c:1827: TINFO: Overall timeout per run is 0h 02m 04s
>  tst_device.c:99: TINFO: Found free device 6 '/dev/loop6'
> +ioctl_loop01.c:119: TCONF: parted exited with 1
>  tst_buffers.c:57: TINFO: Test is using guarded buffers
>  ioctl_loop01.c:84: TPASS: /sys/block/loop6/loop/partscan = 0
>  ioctl_loop01.c:85: TPASS: /sys/block/loop6/loop/autoclear = 0
> @@ -12,18 +13,16 @@
>  ioctl_loop01.c:56: TPASS: get expected lo_flag 12
>  ioctl_loop01.c:58: TPASS: /sys/block/loop6/loop/partscan = 1
>  ioctl_loop01.c:59: TPASS: /sys/block/loop6/loop/autoclear = 1
> -ioctl_loop01.c:68: TPASS: access /dev/loop6p1 succeeds
> -ioctl_loop01.c:74: TPASS: access /sys/block/loop6/loop6p1 succeeds
> +ioctl_loop01.c:62: TINFO: Current environment doesn't have parted disk, skip it
>  ioctl_loop01.c:90: TINFO: Test flag can be clear
>  ioctl_loop01.c:56: TPASS: get expected lo_flag 8
>  ioctl_loop01.c:58: TPASS: /sys/block/loop6/loop/partscan = 1
>  ioctl_loop01.c:59: TPASS: /sys/block/loop6/loop/autoclear = 0
> -ioctl_loop01.c:68: TPASS: access /dev/loop6p1 succeeds
> -ioctl_loop01.c:74: TPASS: access /sys/block/loop6/loop6p1 succeeds
> +ioctl_loop01.c:62: TINFO: Current environment doesn't have parted disk, skip it
>  
>  Summary:
> -passed   13
> +passed   9
>  failed   0
>  broken   0
> -skipped  0
> +skipped  1
>  warnings 0
> 
> That means your change effectively disable that code. => NACK
> 
> in ioctl09.c uses the first command with "test.img", then loop device on the
> second run.
> 
> Surprisingly trying to attach helps 'parted' to use it, although it produces a
> warning:
> 
> +++ testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> @@ -106,6 +106,7 @@ static void setup(void)
>                 tst_brk(TBROK, "Failed to find free loop device");
> 
>         tst_fill_file("test.img", 0, 1024 * 1024, 10);
> +       tst_attach_device(dev_path, "test.img");
> 
>         ret = tst_cmd(cmd_parted, NULL, NULL, TST_CMD_PASS_RETVAL);
>         switch (ret) {
> 
> tst_device.c:99: TINFO: Found free device 9 '/dev/loop9'
> tst_buffers.c:57: TINFO: Test is using guarded buffers
> tst_device.c:176: TWARN: ioctl(/dev/loop9, LOOP_SET_FD, test.img) failed: EBUSY (16)
Thanks for your investigation.
You add tst_attach_device in setup, then second call tst_attach_device
in verify_ioctl_loop trigger this TWARN, I will send second patch.
> ioctl_loop01.c:84: TPASS: /sys/block/loop9/loop/partscan = 0
> ioctl_loop01.c:85: TPASS: /sys/block/loop9/loop/autoclear = 0
> ioctl_loop01.c:86: TPASS: /sys/block/loop9/loop/backing_file = '/tmp/LTP_iocfMLSpX/test.img'
> ioctl_loop01.c:56: TPASS: get expected lo_flag 12
> ioctl_loop01.c:58: TPASS: /sys/block/loop9/loop/partscan = 1
> ioctl_loop01.c:59: TPASS: /sys/block/loop9/loop/autoclear = 1
> ioctl_loop01.c:68: TPASS: access /dev/loop9p1 succeeds
> ioctl_loop01.c:74: TPASS: access /sys/block/loop9/loop9p1 succeeds
> ioctl_loop01.c:90: TINFO: Test flag can be clear
> ioctl_loop01.c:56: TPASS: get expected lo_flag 8
> ioctl_loop01.c:58: TPASS: /sys/block/loop9/loop/partscan = 1
> ioctl_loop01.c:59: TPASS: /sys/block/loop9/loop/autoclear = 0
> ioctl_loop01.c:68: TPASS: access /dev/loop9p1 succeeds
> ioctl_loop01.c:74: TPASS: access /sys/block/loop9/loop9p1 succeeds
> 
> Of course TWARN is also no-go.
> @Jan @Cyril @Li Any hint what am I missing.
> 
> Besides missing there is missing TST_CMD_TCONF_ON_MISSING on the flags (see
> today's fix [1]), but that's minor.
> 
> Kind regards,
> Petr
> 
> [1] https://github.com/linux-test-project/ltp/commit/9691c4b2bea4f772d61ca9e9a93d2087c88f6040

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2] ioctl_loop01.c: Use proper device for partitioning

[Wei Gao via ltp]

This is same patch used on ioctl09,the page cache of loop0 can cache old
version of the partition table which is then used by the partitioning
code. Fix the problem by calling parted against the loop device directly.

Link: https://lore.kernel.org/ltp/20250829141932.31997-1-jack@suse.cz/
Signed-off-by: Wei Gao <wegao@suse.com>
---
 .../kernel/syscalls/ioctl/ioctl_loop01.c      | 26 +++++--------------
 1 file changed, 7 insertions(+), 19 deletions(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
index c9137bf1e..695aaeb0b 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
@@ -78,7 +78,13 @@ static void check_loop_value(int set_flag, int get_flag, int autoclear_field)
 
 static void verify_ioctl_loop(void)
 {
+	const char *const cmd_parted[] = {"parted", "-s", dev_path, "mklabel", "msdos", "mkpart",
+					"primary", "ext4", "1M", "10M", NULL};
+
+	tst_fill_file("test.img", 0, 1024 * 1024, 10);
 	tst_attach_device(dev_path, "test.img");
+	SAFE_CMD(cmd_parted, NULL, NULL);
+
 	attach_flag = 1;
 
 	TST_ASSERT_INT(partscan_path, 0);
@@ -92,34 +98,16 @@ static void verify_ioctl_loop(void)
 
 	tst_detach_device_by_fd(dev_path, dev_fd);
 	dev_fd = SAFE_OPEN(dev_path, O_RDWR);
+
 	attach_flag = 0;
 }
 
 static void setup(void)
 {
-	int ret;
-	const char *const cmd_parted[] = {"parted", "-s", "test.img", "mklabel", "msdos", "mkpart",
-	                                  "primary", "ext4", "1M", "10M", NULL};
-
 	dev_num = tst_find_free_loopdev(dev_path, sizeof(dev_path));
 	if (dev_num < 0)
 		tst_brk(TBROK, "Failed to find free loop device");
 
-	tst_fill_file("test.img", 0, 1024 * 1024, 10);
-
-	ret = tst_cmd(cmd_parted, NULL, NULL, TST_CMD_PASS_RETVAL);
-	switch (ret) {
-	case 0:
-		parted_sup = 1;
-	break;
-	case 255:
-		tst_res(TCONF, "parted binary not installed or failed");
-	break;
-	default:
-		tst_res(TCONF, "parted exited with %i", ret);
-	break;
-	}
-
 	sprintf(partscan_path, "/sys/block/loop%d/loop/partscan", dev_num);
 	sprintf(autoclear_path, "/sys/block/loop%d/loop/autoclear", dev_num);
 	sprintf(backing_path, "/sys/block/loop%d/loop/backing_file", dev_num);
-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2] ioctl_loop01.c: Use proper device for partitioning

[Petr Vorel]

Hi Wei,

> This is same patch used on ioctl09,the page cache of loop0 can cache old
> version of the partition table which is then used by the partitioning
> code. Fix the problem by calling parted against the loop device directly.

LGTM, thanks!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Link: https://lore.kernel.org/ltp/20250829141932.31997-1-jack@suse.cz/
very nit: Link in kernel commits (and I use this approach) is used for the link
to the patch which was merged (kernel maintainer or here LTP maintainer adds
it).  Linking everything else I would use [1].

> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
>  .../kernel/syscalls/ioctl/ioctl_loop01.c      | 26 +++++--------------
>  1 file changed, 7 insertions(+), 19 deletions(-)

> diff --git a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> index c9137bf1e..695aaeb0b 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> +++ b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
> @@ -78,7 +78,13 @@ static void check_loop_value(int set_flag, int get_flag, int autoclear_field)

>  static void verify_ioctl_loop(void)
>  {
> +	const char *const cmd_parted[] = {"parted", "-s", dev_path, "mklabel", "msdos", "mkpart",
> +					"primary", "ext4", "1M", "10M", NULL};
> +
> +	tst_fill_file("test.img", 0, 1024 * 1024, 10);
>  	tst_attach_device(dev_path, "test.img");
> +	SAFE_CMD(cmd_parted, NULL, NULL);

I'll would probably keep the previous approach where the rest of the testing is
now quited:

Now:
...
tst_cmd.c:65: TCONF: Couldn't find 'parted' in $PATH at tst_cmd.c:65

Summary:
passed   0
failed   0
broken   0
skipped  1
warnings 0

Previously:
ioctl_loop01.c:116: TCONF: parted binary not installed or failed
tst_buffers.c:57: TINFO: Test is using guarded buffers
ioctl_loop01.c:84: TPASS: /sys/block/loop2/loop/partscan = 0
ioctl_loop01.c:85: TPASS: /sys/block/loop2/loop/autoclear = 0
ioctl_loop01.c:86: TPASS: /sys/block/loop2/loop/backing_file = '/tmp/LTP_ioco0FWzP/test.img'
ioctl_loop01.c:56: TPASS: get expected lo_flag 12
ioctl_loop01.c:58: TPASS: /sys/block/loop2/loop/partscan = 1
ioctl_loop01.c:59: TPASS: /sys/block/loop2/loop/autoclear = 1
ioctl_loop01.c:62: TINFO: Current environment doesn't have parted disk, skip it
ioctl_loop01.c:90: TINFO: Test flag can be clear
ioctl_loop01.c:56: TPASS: get expected lo_flag 8
ioctl_loop01.c:58: TPASS: /sys/block/loop2/loop/partscan = 1
ioctl_loop01.c:59: TPASS: /sys/block/loop2/loop/autoclear = 0
ioctl_loop01.c:62: TINFO: Current environment doesn't have parted disk, skip it

Summary:
passed   9
failed   0
broken   0
skipped  1
warnings 0

My point was to add TST_CMD_TCONF_ON_MISSING to the previous call. But I was
wrong, that would work the same (skip whole testing on missing 'parted').

...
>  static void setup(void)
>  {
> -	int ret;
> -	const char *const cmd_parted[] = {"parted", "-s", "test.img", "mklabel", "msdos", "mkpart",
> -	                                  "primary", "ext4", "1M", "10M", NULL};
> -
>  	dev_num = tst_find_free_loopdev(dev_path, sizeof(dev_path));
>  	if (dev_num < 0)
>  		tst_brk(TBROK, "Failed to find free loop device");

> -	tst_fill_file("test.img", 0, 1024 * 1024, 10);
> -
> -	ret = tst_cmd(cmd_parted, NULL, NULL, TST_CMD_PASS_RETVAL);
> -	switch (ret) {
> -	case 0:
> -		parted_sup = 1;
> -	break;
> -	case 255:
> -		tst_res(TCONF, "parted binary not installed or failed");
> -	break;
> -	default:
> -		tst_res(TCONF, "parted exited with %i", ret);
> -	break;

Therefore either keeping this, or use if/else equivalent (IMHO more readable):

	ret = tst_cmd(cmd_parted, NULL, NULL, TST_CMD_PASS_RETVAL);
	if (!ret)
		parted_sup = 1;
	else if (ret == 255)
		tst_res(TCONF, "parted binary not installed or failed");
	else
		tst_res(TCONF, "parted exited with %i", ret);

Kind regards,
Petr

> -	}
> -
>  	sprintf(partscan_path, "/sys/block/loop%d/loop/partscan", dev_num);
>  	sprintf(autoclear_path, "/sys/block/loop%d/loop/autoclear", dev_num);
>  	sprintf(backing_path, "/sys/block/loop%d/loop/backing_file", dev_num);

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v3] ioctl_loop01.c: Use proper device for partitioning

[Wei Gao via ltp]

This is same patch used on ioctl09,the page cache of loop0 can cache old
version of the partition table which is then used by the partitioning
code. Fix the problem by calling parted against the loop device directly.
More detail see patch [1].

[1] https://lore.kernel.org/ltp/20250829141932.31997-1-jack@suse.cz/

Signed-off-by: Wei Gao <wegao@suse.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
---
 .../kernel/syscalls/ioctl/ioctl_loop01.c      | 34 ++++++++-----------
 1 file changed, 15 insertions(+), 19 deletions(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
index c9137bf1e..b70e9fc22 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
@@ -78,7 +78,21 @@ static void check_loop_value(int set_flag, int get_flag, int autoclear_field)
 
 static void verify_ioctl_loop(void)
 {
+	int ret;
+	const char *const cmd_parted[] = {"parted", "-s", dev_path, "mklabel", "msdos", "mkpart",
+					"primary", "ext4", "1M", "10M", NULL};
+
+	tst_fill_file("test.img", 0, 1024 * 1024, 10);
 	tst_attach_device(dev_path, "test.img");
+
+	ret = tst_cmd(cmd_parted, NULL, NULL, TST_CMD_PASS_RETVAL);
+	if (!ret)
+		parted_sup = 1;
+	else if (ret == 255)
+		tst_res(TCONF, "parted binary not installed or failed");
+	else
+		tst_res(TCONF, "parted exited with %i", ret);
+
 	attach_flag = 1;
 
 	TST_ASSERT_INT(partscan_path, 0);
@@ -92,34 +106,16 @@ static void verify_ioctl_loop(void)
 
 	tst_detach_device_by_fd(dev_path, dev_fd);
 	dev_fd = SAFE_OPEN(dev_path, O_RDWR);
+
 	attach_flag = 0;
 }
 
 static void setup(void)
 {
-	int ret;
-	const char *const cmd_parted[] = {"parted", "-s", "test.img", "mklabel", "msdos", "mkpart",
-	                                  "primary", "ext4", "1M", "10M", NULL};
-
 	dev_num = tst_find_free_loopdev(dev_path, sizeof(dev_path));
 	if (dev_num < 0)
 		tst_brk(TBROK, "Failed to find free loop device");
 
-	tst_fill_file("test.img", 0, 1024 * 1024, 10);
-
-	ret = tst_cmd(cmd_parted, NULL, NULL, TST_CMD_PASS_RETVAL);
-	switch (ret) {
-	case 0:
-		parted_sup = 1;
-	break;
-	case 255:
-		tst_res(TCONF, "parted binary not installed or failed");
-	break;
-	default:
-		tst_res(TCONF, "parted exited with %i", ret);
-	break;
-	}
-
 	sprintf(partscan_path, "/sys/block/loop%d/loop/partscan", dev_num);
 	sprintf(autoclear_path, "/sys/block/loop%d/loop/autoclear", dev_num);
 	sprintf(backing_path, "/sys/block/loop%d/loop/backing_file", dev_num);
-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v3] ioctl_loop01.c: Use proper device for partitioning

[Petr Vorel]

Hi Wei,

> This is same patch used on ioctl09,the page cache of loop0 can cache old
> version of the partition table which is then used by the partitioning
> code. Fix the problem by calling parted against the loop device directly.
> More detail see patch [1].

> [1] https://lore.kernel.org/ltp/20250829141932.31997-1-jack@suse.cz/

Thanks! Indeed I'm not able to trigger the problem any more.
Tested-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp