Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] sched_football: synchronize with kickoff flag to reduce skew
Date: Thu, 4 Sep 2025 13:42:41 +0200	[thread overview]
Message-ID: <aLl7ConfYPBglqhx@rei.lan> (raw)
In-Reply-To: <20250904110018.GA56668@pevik>

Hi!
> >  static void do_setup(void)
> >  {
> > +	if (!tst_check_preempt_rt())
> > +		tst_brk(TCONF, "Test requires real-time kernel");
> 
> I understood Cyril is really suggesting to keep it [1]. I would also vote to
> keep it (we still have some time to see if it got fixed before release).
> 
> I know we had this discussion in the past (some of your colleague suggesting it
> should not be run on non-RT kernel), so I'm not pushing for it.

I stil do not understand reasons for disabling the test. The POSIX
realtime schedulling classes have to work properly regardless of the
kernel flavor. Why should we turn the test off on non-rt kernel then?

It may make sense to prolong the settling period for non-rt something
as:

...
	if (tst_check_preempt_rt()
		settling_period = 20000;
	else
		settling_period = 200000;


...
	usleep(settling_period);
...


In order to make sure non-rt scheduller has enough time to shuffle the
processes around the available CPUs. But that should be the only
difference.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-09-04 11:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 10:26 [LTP] [PATCH v2] sched_football: synchronize with kickoff flag to reduce skew Li Wang via ltp
2025-09-04 11:00 ` Petr Vorel
2025-09-04 11:42   ` Cyril Hrubis [this message]
2025-09-04 13:14     ` Li Wang via ltp
2025-09-04 15:28       ` Cyril Hrubis
2025-09-05  0:54         ` Li Wang via ltp
2025-09-05  4:03           ` Li Wang via ltp
2025-09-05  6:50             ` Li Wang via ltp
2025-09-05  7:03             ` Petr Vorel
2025-09-05  7:31               ` Petr Vorel
2025-09-05  7:36                 ` Li Wang via ltp
2025-09-05  9:18             ` Cyril Hrubis
2025-09-05 11:50               ` Li Wang via ltp
2025-09-05 12:32                 ` Cyril Hrubis
2025-09-05 12:46                   ` Petr Vorel
2025-09-06  0:58                     ` Li Wang via ltp
2025-09-05 12:49                   ` Li Wang via ltp
2025-09-05 13:45                     ` Cyril Hrubis
2025-09-05 14:48                       ` Li Wang via ltp
2025-09-04 18:26       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLl7ConfYPBglqhx@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox