[LTP] [PATCH v1] mount08.c: Add min_kver for test case

[LTP] [PATCH v1] mount08.c: Add min_kver for test case

[Wei Gao via ltp]

Signed-off-by: Wei Gao <wegao@suse.com>
---
 testcases/kernel/syscalls/mount/mount08.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/syscalls/mount/mount08.c b/testcases/kernel/syscalls/mount/mount08.c
index fb2b28736..1c454cab4 100644
--- a/testcases/kernel/syscalls/mount/mount08.c
+++ b/testcases/kernel/syscalls/mount/mount08.c
@@ -63,6 +63,7 @@ static struct tst_test test = {
 	.test_all = run,
 	.needs_root = 1,
 	.mntpoint = MNTPOINT,
+	.min_kver = "6.12",
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "d80b065bb172"},
 		{}
-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] mount08.c: Add min_kver for test case

[Cyril Hrubis]

Hi!
Again, there has to be explanation here why this is needed...

But given that this is a regression test for a security hardening that
was added into 6.12 it's okay if the test fails on older kernel,
moreover hiding the failure may make the system more vunerable.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] mount08.c: Add min_kver for test case

[Martin Doucha]

On 9/29/25 14:05, Cyril Hrubis wrote:
> Hi!
> Again, there has to be explanation here why this is needed...
> 
> But given that this is a regression test for a security hardening that
> was added into 6.12 it's okay if the test fails on older kernel,
> moreover hiding the failure may make the system more vunerable.

Hi,
I agree with rejecting this patch. If a kernel is not patched, the test 
should fail regardless of kernel version.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] mount08.c: Add min_kver for test case

[Petr Vorel]

Hi all,

> On 9/29/25 14:05, Cyril Hrubis wrote:
> > Hi!
> > Again, there has to be explanation here why this is needed...

> > But given that this is a regression test for a security hardening that
> > was added into 6.12 it's okay if the test fails on older kernel,
> > moreover hiding the failure may make the system more vunerable.

> Hi,
> I agree with rejecting this patch. If a kernel is not patched, the test
> should fail regardless of kernel version.

For a record, d80b065bb172 is a merge commit, the fix contains actually 7
commits. IMHO none of them has been backported to any stable / LTS kernel.  I'll
ask Christian and Greg if it makes sense to backport it.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] mount08.c: Add min_kver for test case

[Petr Vorel]

Hi all,

...
> For a record, d80b065bb172 is a merge commit, the fix contains actually 7
> commits. IMHO none of them has been backported to any stable / LTS kernel.  I'll
> ask Christian and Greg if it makes sense to backport it.

asked [1]. (unfortunately I forgot to delete message-id and From: from the
original message).

Kind regards,
Petr

[1] https://lore.kernel.org/all/20240806-work-procfs-v1-0-fb04e1d09f0c@kernel.org/

> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] mount08.c: Add min_kver for test case

[Petr Vorel]

Hi all,

...
> ...
> > For a record, d80b065bb172 is a merge commit, the fix contains actually 7
> > commits. IMHO none of them has been backported to any stable / LTS kernel.  I'll
> > ask Christian and Greg if it makes sense to backport it.

> asked [1]. (unfortunately I forgot to delete message-id and From: from the
> original message).

FYI answer from Aleksa [2] suggests it will not be backported, but let's wait
if somebody else give his opinion. Anyway, I'm not advocating for this patch
(to add .min_kver = "6.12"), although it wouldn't harm to document it in the
test that unlike kernel folks which consider it as a "new feature" we consider
it as a "security fix".

Kind regards,
Petr

> Kind regards,
> Petr

> [1] https://lore.kernel.org/all/20240806-work-procfs-v1-0-fb04e1d09f0c@kernel.org/
[2] https://lore.kernel.org/linux-fsdevel/2025-09-30-emerald-unsure-pillow-prism-nKVGLB@cyphar.com/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp