From: Cyril Hrubis <chrubis@suse.cz>
To: Jack Morgan <jmorgan@naotchy.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] statmount09.c: Enable mnt_ns_id for STATMOUNT_MNT_NS_ID
Date: Mon, 29 Sep 2025 12:58:17 +0200 [thread overview]
Message-ID: <aNpmSc71aNmPoEDY@yuki.lan> (raw)
In-Reply-To: <20250926203502.1350861-1-jmorgan@naotchy.com>
Hi!
Since we are nearing next release I pushed the patch with minor
adjustenments, thanks!
> statmount09.c: Enable mnt_ns_id for STATMOUNT_MNT_NS_ID
I've removed this duplicate line.
> When HAVE_STATMOUNT_MNT_NS_ID is defined, use mnt_ns_id
> for statmount09 test case. Otherswise, use mnt_id.
>
> Fixes: #1260
Replaced this with a full link to the issue (it's easier to dig things
up that way).
> Signed-off-by: Jack Morgan <jmorgan@naotchy.com>
> ---
> testcases/kernel/syscalls/statmount/statmount09.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/statmount/statmount09.c b/testcases/kernel/syscalls/statmount/statmount09.c
> index 20c76ba24..03f54f2b8 100644
> --- a/testcases/kernel/syscalls/statmount/statmount09.c
> +++ b/testcases/kernel/syscalls/statmount/statmount09.c
> @@ -39,7 +39,11 @@ static void run(void)
> return;
>
> TST_EXP_EQ_LI(st_mount->mask, STATMOUNT_MNT_NS_ID);
> - TST_EXP_EQ_LI(st_mount->mnt_ns_id, mnt_ns_id);
> +#if !defined(HAVE_STRUCT_STATMOUNT) || defined(HAVE_STRUCT_STATMOUNT_MNT_NS_ID)
> + TST_EXP_EQ_LI(st_mount->mnt_ns_id, mnt_ns_id);
> +#else
> + tst_res(TCONF, "statmount.mnt_ns_id not available in current headers, skipping check");
Replaced the spaces with tabs, we use tabs in LTP (hint: 'make check'
will print errors and warnings to catch such issues).
And also shortened the line a bit, the ", skipping check" part is
redundand since the message type is TCONF already.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2025-09-29 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 20:35 [LTP] [PATCH v3] statmount09.c: Enable mnt_ns_id for STATMOUNT_MNT_NS_ID Jack Morgan
2025-09-29 10:58 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNpmSc71aNmPoEDY@yuki.lan \
--to=chrubis@suse.cz \
--cc=jmorgan@naotchy.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox