From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93DD5CCA472 for ; Tue, 7 Oct 2025 12:28:58 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 248CA3CE49B for ; Tue, 7 Oct 2025 14:28:57 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 7822F3CDDB8 for ; Tue, 7 Oct 2025 14:28:41 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 0B9FC600790 for ; Tue, 7 Oct 2025 14:28:40 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A7AF022AEC; Tue, 7 Oct 2025 12:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1759840119; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rHgg22COCAlJZG7Cj65P+kWjwR0mgzg3vi8IMj2KfQE=; b=rHb/EjemQukXn7PGC+/DFhFP2JJIkkQpNHO9MhKc6Zxq2O15v/Zce/GIiLWeCsodzjhHRO FJO8Zr5i9Ce7Bhsk2Hmz5u/RrYJQ//g6Ns09QmUNCdtXuCttf/vrgUD/J9iomRBic4Mv6u Dz+spQ1zOdv1LVvDlpVWpO4oODf66Ks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1759840119; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rHgg22COCAlJZG7Cj65P+kWjwR0mgzg3vi8IMj2KfQE=; b=lG3ve3meVHtvPsG2hkEH1XosGBgD7mikOUJkeWm46W7LIbceqs8yUCqOkmOyM8eC89vVkJ R2lXn+ZH6qOM8wCg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="rHb/Ejem"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lG3ve3me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1759840119; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rHgg22COCAlJZG7Cj65P+kWjwR0mgzg3vi8IMj2KfQE=; b=rHb/EjemQukXn7PGC+/DFhFP2JJIkkQpNHO9MhKc6Zxq2O15v/Zce/GIiLWeCsodzjhHRO FJO8Zr5i9Ce7Bhsk2Hmz5u/RrYJQ//g6Ns09QmUNCdtXuCttf/vrgUD/J9iomRBic4Mv6u Dz+spQ1zOdv1LVvDlpVWpO4oODf66Ks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1759840119; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rHgg22COCAlJZG7Cj65P+kWjwR0mgzg3vi8IMj2KfQE=; b=lG3ve3meVHtvPsG2hkEH1XosGBgD7mikOUJkeWm46W7LIbceqs8yUCqOkmOyM8eC89vVkJ R2lXn+ZH6qOM8wCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 96DAF13AAC; Tue, 7 Oct 2025 12:28:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Mm+vI3cH5Wg4DgAAD6G6ig (envelope-from ); Tue, 07 Oct 2025 12:28:39 +0000 Date: Tue, 7 Oct 2025 14:29:29 +0200 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20251007-xattrat-v2-0-bf458fa66358@suse.com> <20251007-xattrat-v2-3-bf458fa66358@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251007-xattrat-v2-3-bf458fa66358@suse.com> X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email, suse.cz:dkim, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Queue-Id: A7AF022AEC X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.7 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 03/10] setxattr01: add setxattrat variant X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! Looks good to me: Reviewed-by: Cyril Hrubis ... > if (TST_RET == -1 && TST_ERR == EOPNOTSUPP) > - tst_brk(TCONF, "setxattr(2) not supported"); > + tst_brk(TCONF, "%s(2) not supported", sysname); Can we please, in a subsequent patch, convert this part to our standard approach where we check for the availability in the test setup and expect the syscalls to be present if kernel is new enough? -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp