[LTP] [PATCH v2 05/10] setxattr03: add setxattrat variant

Andrea Cervesato
2025-10-07T06:50:02Z

From: Andrea Cervesato <andrea.cervesato@suse.com>

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
testcases/kernel/syscalls/setxattr/setxattr03.c | 35 +++++++++++++++++++------
1 file changed, 27 insertions(+), 8 deletions(-)

diff --git a/testcases/kernel/syscalls/setxattr/setxattr03.c b/testcases/kernel/syscalls/setxattr/setxattr03.c
index 0b5b48a55..2465edd69 100644
--- a/testcases/kernel/syscalls/setxattr/setxattr03.c
+++ b/testcases/kernel/syscalls/setxattr/setxattr03.c
@@ -12,7 +12,12 @@
*/

#define _GNU_SOURCE
+
#include "config.h"
+#include "tst_test.h"
+
+#ifdef HAVE_SYS_XATTR_H
+
#include <sys/ioctl.h>
#include <sys/types.h>
#include <sys/stat.h>
@@ -24,14 +29,10 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#ifdef HAVE_SYS_XATTR_H
-# include <sys/xattr.h>
-#endif
#include "lapi/fs.h"
+#include "lapi/xattr.h"
+#include <sys/xattr.h>

-#include "tst_test.h"
-
-#if defined HAVE_SYS_XATTR_H
#define XATTR_TEST_KEY "user.testkey"
#define XATTR_TEST_VALUE "this is a test value"
#define XATTR_TEST_VALUE_SIZE (sizeof(XATTR_TEST_VALUE) - 1)
@@ -76,11 +77,23 @@ static struct test_case tc[] = {

static int immu_fd;
static int append_fd;
+static int tmpdir_fd = -1;

static void verify_setxattr(unsigned int i)
{
- TEST(setxattr(tc[i].fname, tc[i].key, tc[i].value, tc[i].size,
- tc[i].flags));
+ if (tst_variant) {
+ struct xattr_args args = {
+ .value = (uint64_t)tc[i].value,
+ .size = tc[i].size,
+ .flags = tc[i].flags,
+ };
+
+ TEST(setxattrat(tmpdir_fd, tc[i].fname, AT_SYMLINK_NOFOLLOW,
+ tc[i].key, &args, sizeof(args)));
+ } else {
+ TEST(setxattr(tc[i].fname, tc[i].key, tc[i].value, tc[i].size,
+ tc[i].flags));
+ }

if (!TST_RET) {
tst_res(TFAIL, "%s succeeded unexpectedly", tc[i].desc);
@@ -143,10 +156,15 @@ static void setup(void)
if (set_append_on(append_fd))
tst_brk(TBROK | TERRNO, "Set %s append-only failed",
APPEND_FILE);
+
+ tmpdir_fd = SAFE_OPEN(tst_tmpdir_path(), O_DIRECTORY);
}

static void cleanup(void)
{
+ if (tmpdir_fd != -1)
+ SAFE_CLOSE(tmpdir_fd);
+
if ((immu_fd > 0) && set_immutable_off(immu_fd))
tst_res(TWARN | TERRNO, "Unset %s immutable failed",
IMMU_FILE);
@@ -167,6 +185,7 @@ static struct tst_test test = {
.cleanup = cleanup,
.test = verify_setxattr,
.tcnt = ARRAY_SIZE(tc),
+ .test_variants = 2,
.needs_tmpdir = 1,
.needs_root = 1,
};

--
2.51.0