public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] isofs: Add ISO9660 kernel config requirement
@ 2025-10-24 12:56 Anders Roxell
  2025-10-24 15:39 ` Petr Vorel
  2025-10-27  9:02 ` Cyril Hrubis
  0 siblings, 2 replies; 5+ messages in thread
From: Anders Roxell @ 2025-10-24 12:56 UTC (permalink / raw)
  To: ltp; +Cc: benjamin.copeland, dan.carpenter

The isofs test requires ISO9660 filesystem support to test mounting and
accessing ISO images. Without CONFIG_ISO9660_FS enabled, the test fails
with "unknown filesystem type 'iso9660'" errors during mount attempts,
resulting in 140 failed test cases.

Add the CONFIG_ISO9660_FS kernel configuration requirement to ensure the
test properly skips with TCONF on systems without ISO9660 support,
either built-in or as a module.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 testcases/kernel/fs/iso9660/isofs.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/fs/iso9660/isofs.sh b/testcases/kernel/fs/iso9660/isofs.sh
index 088e062d67c6..c66a284cebf1 100755
--- a/testcases/kernel/fs/iso9660/isofs.sh
+++ b/testcases/kernel/fs/iso9660/isofs.sh
@@ -11,6 +11,7 @@
 
 TST_NEEDS_CMDS="mount umount"
 TST_NEEDS_TMPDIR=1
+TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y | CONFIG_ISO9660_FS=m"
 TST_TESTFUNC=do_test
 TST_CNT=3
 TST_SETUP="setup"
-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH] isofs: Add ISO9660 kernel config requirement
  2025-10-24 12:56 [LTP] [PATCH] isofs: Add ISO9660 kernel config requirement Anders Roxell
@ 2025-10-24 15:39 ` Petr Vorel
  2025-10-27  9:02 ` Cyril Hrubis
  1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2025-10-24 15:39 UTC (permalink / raw)
  To: Anders Roxell; +Cc: benjamin.copeland, dan.carpenter, ltp

Hi Anders,

> The isofs test requires ISO9660 filesystem support to test mounting and
> accessing ISO images. Without CONFIG_ISO9660_FS enabled, the test fails
> with "unknown filesystem type 'iso9660'" errors during mount attempts,
> resulting in 140 failed test cases.

> Add the CONFIG_ISO9660_FS kernel configuration requirement to ensure the
> test properly skips with TCONF on systems without ISO9660 support,
> either built-in or as a module.

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  testcases/kernel/fs/iso9660/isofs.sh | 1 +
>  1 file changed, 1 insertion(+)

> diff --git a/testcases/kernel/fs/iso9660/isofs.sh b/testcases/kernel/fs/iso9660/isofs.sh
> index 088e062d67c6..c66a284cebf1 100755
> --- a/testcases/kernel/fs/iso9660/isofs.sh
> +++ b/testcases/kernel/fs/iso9660/isofs.sh
> @@ -11,6 +11,7 @@

>  TST_NEEDS_CMDS="mount umount"
>  TST_NEEDS_TMPDIR=1
> +TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y | CONFIG_ISO9660_FS=m"

LGTM
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

>  TST_TESTFUNC=do_test
>  TST_CNT=3
>  TST_SETUP="setup"

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH] isofs: Add ISO9660 kernel config requirement
  2025-10-24 12:56 [LTP] [PATCH] isofs: Add ISO9660 kernel config requirement Anders Roxell
  2025-10-24 15:39 ` Petr Vorel
@ 2025-10-27  9:02 ` Cyril Hrubis
  2025-10-27 14:22   ` Anders Roxell
  2025-10-29  8:16   ` Petr Vorel
  1 sibling, 2 replies; 5+ messages in thread
From: Cyril Hrubis @ 2025-10-27  9:02 UTC (permalink / raw)
  To: Anders Roxell; +Cc: dan.carpenter, ltp, benjamin.copeland

Hi!
>  TST_NEEDS_CMDS="mount umount"
>  TST_NEEDS_TMPDIR=1
> +TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y | CONFIG_ISO9660_FS=m"

If you add just TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS" it will match both
=y and =m I've added this shortcut to the library so that we do not need
to write it as you did above.

>  TST_TESTFUNC=do_test
>  TST_CNT=3
>  TST_SETUP="setup"
> -- 
> 2.51.0
> 

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH] isofs: Add ISO9660 kernel config requirement
  2025-10-27  9:02 ` Cyril Hrubis
@ 2025-10-27 14:22   ` Anders Roxell
  2025-10-29  8:16   ` Petr Vorel
  1 sibling, 0 replies; 5+ messages in thread
From: Anders Roxell @ 2025-10-27 14:22 UTC (permalink / raw)
  To: Cyril Hrubis; +Cc: dan.carpenter, ltp, benjamin.copeland

On Mon, 27 Oct 2025 at 10:03, Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> >  TST_NEEDS_CMDS="mount umount"
> >  TST_NEEDS_TMPDIR=1
> > +TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y | CONFIG_ISO9660_FS=m"
>
> If you add just TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS" it will match both
> =y and =m I've added this shortcut to the library so that we do not need
> to write it as you did above.

Oh great, I didn't know. I'll send a v2 shortly.

Cheers,
Anders

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH] isofs: Add ISO9660 kernel config requirement
  2025-10-27  9:02 ` Cyril Hrubis
  2025-10-27 14:22   ` Anders Roxell
@ 2025-10-29  8:16   ` Petr Vorel
  1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2025-10-29  8:16 UTC (permalink / raw)
  To: Cyril Hrubis; +Cc: benjamin.copeland, dan.carpenter, ltp

> Hi!
> >  TST_NEEDS_CMDS="mount umount"
> >  TST_NEEDS_TMPDIR=1
> > +TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y | CONFIG_ISO9660_FS=m"

> If you add just TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS" it will match both
> =y and =m I've added this shortcut to the library so that we do not need
> to write it as you did above.

Thanks for catching this, Cyril!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-10-29  8:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-24 12:56 [LTP] [PATCH] isofs: Add ISO9660 kernel config requirement Anders Roxell
2025-10-24 15:39 ` Petr Vorel
2025-10-27  9:02 ` Cyril Hrubis
2025-10-27 14:22   ` Anders Roxell
2025-10-29  8:16   ` Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox