Re: [LTP] [PATCH 2/2] ioctl_sg01: Print buffer contents on failure

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> +static void dump_hex(const char *str, size_t size)
> +{
> +	size_t i;
> +
> +	for (; size && !str[size - 1]; size--)
> +		;
> +
> +	for (i = 0; i < size; i++) {
> +		if (i && (i % 32) == 0)
> +			printf("\n");
> +		else if (i && (i % 4) == 0)
> +			printf(" ");
> +
> +		printf("%02x", (unsigned int)str[i]);
> +	}
> +
> +	printf("\n");
> +}
> +
>  static void setup(void)
>  {
>  	const char *devpath = find_generic_scsi_device(O_RDONLY, 1);
> @@ -135,6 +154,7 @@ static void run(void)
>  
>  	for (i = 0; i < 100; i++) {
>  		TEST(ioctl(devfd, SG_IO, &query));
> +		buffer[BUF_SIZE] = '\0';
>  
>  		if (TST_RET != 0 && TST_RET != -1)
>  			tst_brk(TBROK|TTERRNO, "Invalid ioctl() return value");
> @@ -143,6 +163,8 @@ static void run(void)
>  		for (j = 0; j < BUF_SIZE; j++) {
>  			if (buffer[j]) {
>  				tst_res(TFAIL, "Kernel memory leaked");
> +				tst_res(TINFO, "Buffer contents: %s", buffer);

Any reason why we don't use tst_res_hexd() instead?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp