From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: helena.anna.dubel@intel.com, tomasz.ossowski@intel.com,
rafael.j.wysocki@intel.com, Piotr Kubaj <piotr.kubaj@intel.com>,
daniel.niestepski@intel.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] thermal: add new test group
Date: Mon, 10 Nov 2025 11:33:38 +0100 [thread overview]
Message-ID: <aRG_gvx7AQQt33pf@yuki.lan> (raw)
In-Reply-To: <20251106165012.GA1064259@pevik>
Hi!
> > First of all, the tst_test.sh test library is in maitenance mode and new
> > shell tests should use the tst_loader.sh instead. Have a look at the
> > testcases/kernel/mem/vma/vma05.sh test on how does it look like.
>
> Piotr, first thank you for submitting a test.
>
> My wish would be no more shell based test. shell loader is kind of compromise to
> improve existing shell based tests, but I'm not happy to see yet new more tests
> in shell (we in SUSE will be then actively rewriting it into C :( to avoid
> various problems with shell tests).
Honestly for a test that is as simple as this one shell may be fine.
Anything more complex that this should be probably written in C.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-11-10 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 11:43 [LTP] [PATCH] thermal: add new test group Piotr Kubaj
2025-11-06 12:46 ` Cyril Hrubis
2025-11-06 16:50 ` Petr Vorel
2025-11-10 10:33 ` Cyril Hrubis [this message]
2025-11-10 10:31 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2026-01-19 8:51 Piotr Kubaj
2026-01-19 13:20 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRG_gvx7AQQt33pf@yuki.lan \
--to=chrubis@suse.cz \
--cc=daniel.niestepski@intel.com \
--cc=helena.anna.dubel@intel.com \
--cc=ltp@lists.linux.it \
--cc=piotr.kubaj@intel.com \
--cc=pvorel@suse.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=tomasz.ossowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox