Re: [LTP] [PATCH] Ignore cve-2022-2590_64bit CVE for Kernel versions below 5.16+

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> CVE 2022-2590_64bit is applicable only for kernel versions 5.16 onwards.

Why? What happens if you run the test on an older kernel? This
information should be written here.

> Add kernel version check to skip/Ignore the test case.
> Test Module: vts_ltp_test_arm_64
> Test Case: cve.cve-2022-2590_64bit#cve.cve-2022-2590_64bit
> GBUG: 418679607
> 
> Change-Id: Ibbb18a168b727725faab2beb6841640e034fc468
> ---
>  testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> index 2c7ad00f2..0651ae122 100644
> --- a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> +++ b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> @@ -19,6 +19,7 @@
>  #include <stdbool.h>
>  #include <pwd.h>
>  
> +#include "tst_kvercmp.h"
>  #include "tst_test.h"
>  
>  #define TMP_DIR "tmp_dirtyc0w_shmem"
> @@ -41,6 +42,9 @@ static void sighandler(int sig)
>  
>  static void setup(void)
>  {
> +	if (tst_kvercmp(5, 16, 0) < 0) {
> +		tst_brk(TCONF, "Test requires kernel 5.16.0 or newer for CVE-2022-2590 fix");
> +	}

You should use the .min_kver field in the tst_test structure instead.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp