From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6251BCFD364 for ; Tue, 25 Nov 2025 09:49:00 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3A36E3CD4E4 for ; Tue, 25 Nov 2025 10:48:58 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 582C43CBEC7 for ; Tue, 25 Nov 2025 10:48:42 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id BACF5600121 for ; Tue, 25 Nov 2025 10:48:41 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1E93022715; Tue, 25 Nov 2025 09:48:41 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 11E8E3EA63; Tue, 25 Nov 2025 09:48:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id v1BaBHl7JWmSUwAAD6G6ig (envelope-from ); Tue, 25 Nov 2025 09:48:41 +0000 Date: Tue, 25 Nov 2025 10:49:34 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20251124164307.20516-1-chrubis@suse.cz> <20251124175951.GA127343@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251124175951.GA127343@pevik> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 1E93022715 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Virus-Scanned: clamav-milter 1.0.9 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2] doc: Add basic shell test description X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > + 'shell_lib': (f'{ltp_repo}/blob/master/testcases/lib/%s', '%s'), > +1. I was thinking about it previously for C helpers, then I preferred to show > full path. I guess I'll later use 'shell_lib' prefix for these. I suppose we can > keep lib/*.c path, but sure, we could also (later) add 'lib' and 'include'. Well this is going to be easier to maintain if we ever decided to move the content of the testcases/lib into a top level directory, where it probably belongs. > I wish extlinks module allow to pass more params than just one. Yes. > +++ doc/developers/api_shell_tests.rst > @@ -87,9 +87,9 @@ Test setup and cleanup > ---------------------- > > The test setup and cleanup functions are optional and passed via variables. > -Similarily to the C API the setup is executed exactly once at the start of the > +Similarly to the C API the setup is executed exactly once at the start of the > test and the test cleanup is executed at the test end or when test was > -interrupted by ref:`tst_brk`. > +interrupted by :ref:`tst_brk`. > > .. literalinclude:: ../../testcases/lib/tests/shell_loader_setup_cleanup.sh > - :language: shell > + :language: shell Fixed and pushed, thanks. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp