[LTP] [PATCH] CI: do not checkout submodules

[LTP] [PATCH] CI: do not checkout submodules

[Cyril Hrubis]

This was originally added so that kirk installation is tested. The
problem is that this brings random failures when git.kernel.org timeouts
when we are checking out submodules that are not needed for the build
and neither for the installation.

Unfortunatelly there is no support for selective submodule installation
in github checkout action. There is an issue and pull request hanging:

https://github.com/actions/checkout/pull/1866
https://github.com/actions/checkout/issues/1969

It looks like if we wanted to checkout only kirk submodule we would have
to install git and run all the commands ourselves in the CI, which I
would like to avoid. Hence this commit removes the submodules checkout
from the CI, with that we sacrifice kirk installation testing but avoid
random failures.

Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 .github/workflows/ci-docker-build.yml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.github/workflows/ci-docker-build.yml b/.github/workflows/ci-docker-build.yml
index f7c779f63..09eb8bb6d 100644
--- a/.github/workflows/ci-docker-build.yml
+++ b/.github/workflows/ci-docker-build.yml
@@ -125,8 +125,6 @@ jobs:
 
     - name: Git checkout
       uses: actions/checkout@v1
-      with:
-        submodules: 'true'
 
     - name: Install additional packages
       run: |
-- 
2.51.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] CI: do not checkout submodules

[Petr Vorel]

Hi Cyril,

> This was originally added so that kirk installation is tested. The
> problem is that this brings random failures when git.kernel.org timeouts
> when we are checking out submodules that are not needed for the build
> and neither for the installation.

> Unfortunatelly there is no support for selective submodule installation
> in github checkout action. There is an issue and pull request hanging:

> https://github.com/actions/checkout/pull/1866
> https://github.com/actions/checkout/issues/1969

> It looks like if we wanted to checkout only kirk submodule we would have
> to install git and run all the commands ourselves in the CI, which I
> would like to avoid. Hence this commit removes the submodules checkout
> from the CI, with that we sacrifice kirk installation testing but avoid
> random failures.

> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>

I'm ok with it.
nit: I'd mention it is actually a revert of 9cde2740cc.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> ---
>  .github/workflows/ci-docker-build.yml | 2 --
>  1 file changed, 2 deletions(-)

> diff --git a/.github/workflows/ci-docker-build.yml b/.github/workflows/ci-docker-build.yml
> index f7c779f63..09eb8bb6d 100644
> --- a/.github/workflows/ci-docker-build.yml
> +++ b/.github/workflows/ci-docker-build.yml
> @@ -125,8 +125,6 @@ jobs:

>      - name: Git checkout
>        uses: actions/checkout@v1
> -      with:
> -        submodules: 'true'

>      - name: Install additional packages
>        run: |

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] CI: do not checkout submodules

[Cyril Hrubis]

Hi!
> > Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> 
> I'm ok with it.
> nit: I'd mention it is actually a revert of 9cde2740cc.

Added and pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp