Re: [LTP] [PATCH v2 2/2] doc: Add ground rules page

Li Wang via ltp
2025-12-16T11:25:24Z

On Tue, Dec 16, 2025 at 7:22 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > It's really good to write these rules down, especially since maintainers
> > can reuse them in patch reviews to comment on issues and avoid repeatedly
> > responding to the same questions. Below are what I can think of:
> >
> > Don’t require root unless it’s essential
> > ============================
> > If root/caps are needed, say why in the test output. Drop privileges for
> > the part that doesn’t need them (and avoid running the whole test as
> > root “because it’s easier”).
> >
> >
> > Always clean up, even on failure
> > ==========================
> > Every test should leave the system as it found it: unmount, restore
> sysctls,
> > delete temp files/dirs, kill spawned processes, remove
> cgroups/namespaces,
> > detach loop devices, restore ulimits, etc. Cleanup must run on early-exit
> > paths too.
> >
> >
> > Respect LTP portability goals
> > ===========================
> > Avoid nonstandard libc APIs when a portable equivalent exists; don’t
> assume
> > 64-bit,
> > page size, endianness, or particular tool versions.
>
> Shall I send a V3 with these included, or do you want to send a patch on
> the top of the one I send?
>

Cyril, you can add those topics we discussed into your patch v3 directly.

--
Regards,
Li Wang