From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86191D61020 for ; Thu, 29 Jan 2026 15:05:31 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id EB0AC3CC2F5 for ; Thu, 29 Jan 2026 16:05:29 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 3440B3CC218 for ; Thu, 29 Jan 2026 16:05:10 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id AD7B0200B3E for ; Thu, 29 Jan 2026 16:05:09 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 896C934170; Thu, 29 Jan 2026 15:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1769699108; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJSG1GmP1TPg7O0H4zeY1/1f/4nbWJZG1LKd5M3zYGk=; b=spLeXGFBPzj9Tq8wX8kbA9ADszjUk6HHeFeL7P92cEZkjacKpVUz0qDHgmMIR+WmtPTq52 OgHYjDYX7i4ZhTtL15rqyslYUBmG3m/ZOxwl9zq80PrE+R8A90Vd4mfnNzSqsimW5rZXSu hEV2h43hFGXIgdkUozArdRvqk7DzU3s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1769699108; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJSG1GmP1TPg7O0H4zeY1/1f/4nbWJZG1LKd5M3zYGk=; b=2nXkCx/WkMtY8kPyyo9fBEKgGLHIjd1nSu492z7eABc+HsYBUYRwoD/lsT8St3GuQZ1Iv2 XM4a3e63CWgQSGCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1769699108; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJSG1GmP1TPg7O0H4zeY1/1f/4nbWJZG1LKd5M3zYGk=; b=spLeXGFBPzj9Tq8wX8kbA9ADszjUk6HHeFeL7P92cEZkjacKpVUz0qDHgmMIR+WmtPTq52 OgHYjDYX7i4ZhTtL15rqyslYUBmG3m/ZOxwl9zq80PrE+R8A90Vd4mfnNzSqsimW5rZXSu hEV2h43hFGXIgdkUozArdRvqk7DzU3s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1769699108; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJSG1GmP1TPg7O0H4zeY1/1f/4nbWJZG1LKd5M3zYGk=; b=2nXkCx/WkMtY8kPyyo9fBEKgGLHIjd1nSu492z7eABc+HsYBUYRwoD/lsT8St3GuQZ1Iv2 XM4a3e63CWgQSGCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5450F3EA61; Thu, 29 Jan 2026 15:05:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LQAMEyR3e2n6GAAAD6G6ig (envelope-from ); Thu, 29 Jan 2026 15:05:08 +0000 Date: Thu, 29 Jan 2026 16:06:24 +0100 From: Cyril Hrubis To: Jan Stancek Message-ID: References: <20251215161353.GA282302@pevik> <20251215165247.GC282302@pevik> <20260107160656.GB791855@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; URIBL_BLOCKED(0.00)[suse.cz:email]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:email] X-Virus-Scanned: clamav-milter 1.0.9 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] ioctl_pidfd02-06: Add CONFIG_USER_NS and CONFIG_PID_NS to needs_kconfigs X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it, Terry Tritton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > > Because that was my question - really always prefer kconfig even there is a > > > simple runtime solution? I'd like to have some "rule" like conclusion we can > > > point during review. > > > > I think that from a long term view this is going to be simpler solution > > than having many different types of checks. The less diverse these > > checks are the easier they are to review and maintain. Hence I lean > > towards kernel config checks even though they are slower (mostly > > unmeasurable on today's harware) than the alternatives. > > I think I lean opposite way, and rather have a check for right > environment to support the test. > You can have feature X enabled in kernel config, but still disabled > later at boot/runtime > (e.g. max_user_namespaces=0), or a module simply not being loaded. That is a good catch. Maybe the best way forward would be to add hooks for certain config options into the LTP kernel config parser that would do additional runtime checks. That way we would have both the information on which kernel configs should be enabled in test metadata as well as runtime checks. What about eventually adding something as: diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c index 9bcd57721..f6abe6cc7 100644 --- a/lib/tst_kconfig.c +++ b/lib/tst_kconfig.c @@ -110,6 +110,18 @@ static void close_kconfig(FILE *fp) fclose(fp); } +static void runtime_check(struct tst_kconfig_var *var) +{ + if (strstr(var->id, "CONFIG_USER_NS")) { + if (!tst_user_ns_enabled()) { + tst_res(TINFO, "CONFIG_USER_NS present but runtime is disabled"); + var->val = 'n'; + } + } else if (...) + ... + } +} + static inline int kconfig_parse_line(const char *line, struct tst_kconfig_var *vars, unsigned int vars_len) @@ -183,9 +195,11 @@ out: switch (val[0]) { case 'y': vars[i].choice = 'y'; + runtime_check(&vars[i]); return 1; case 'm': vars[i].choice = 'm'; + runtime_check(&vars[i]); return 1; } } -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp