Re: [LTP] [PATCH 4/4] kirk: Remove runltp-ng symlink

Petr Vorel
2026-02-04T12:47:12Z

Hi Andrea, all,
> Hi!

> On Wed Feb 4, 2026 at 12:53 PM CET, Petr Vorel wrote:
> > kirk is here long enough to remove the symlink.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > tools/kirk/Makefile | 2 --
> > 1 file changed, 2 deletions(-)

> > diff --git a/tools/kirk/Makefile b/tools/kirk/Makefile
> > index 876eb3e2ed..859afde6e6 100644
> > --- a/tools/kirk/Makefile
> > +++ b/tools/kirk/Makefile
> > @@ -17,8 +17,6 @@ ifneq ($(wildcard $(abs_srcdir)/kirk-src/libkirk/*.py),)
> > install -m 00644 $(abs_srcdir)/kirk-src/libkirk/*.py $(BASE_DIR)/libkirk
> > install -m 00644 $(abs_srcdir)/kirk-src/libkirk/channels/*.py $(BASE_DIR)/libkirk/channels
> > install -m 00775 $(abs_srcdir)/kirk-src/kirk $(BASE_DIR)/kirk
> > -
> > - cd $(BASE_DIR) && ln -sf kirk runltp-ng
> > endif

> > include $(top_srcdir)/include/mk/generic_leaf_target.mk

> This is the only point where im not 100% sure. I'm wondering if we
> should keep a symlink to `runltp`, just in case people will have CI
> working on LTP.

I'm not sure if hiding 'kirk' under 'runltp' symlink is a good idea. If yes,
there should be a big warning if people run it via symlink (detect in
kirk-src/kirk that it was run via 'runltp').

Do you agree with removing 'runltp-ng' symlink?

Kind regards,
Petr