Re: [LTP] [PATCH] lib: tst_kconfig: Add runtime checks

[Li Wang via ltp <ltp@lists.linux.it>]

> > +static void runtime_check(struct tst_kconfig_var *var)
> > +{
> > +	size_t i;
> > +
> > +	for (i = 0; runtime_checks[i].config; i++) {
> > +		if (strcmp(runtime_checks[i].config, var->id))
> > +			continue;
> > +
> > +		tst_res(TDEBUG, "Running runtime check for '%s'", var->id);
> This will not work since Li's change:
> aa5a6fcdcd ("lib: suppress early TDEBUG output before context initialization")
> 
> @Li I'm not sure what "unless explicitly enabled" means, but I guess we cannot
> simple enable it for the test library (following patch). I vote to either revert
> aa5a6fcdcd or change it (effectively revert it, but keep doc and the rest of the
> code).
> 
> I understand having the output in each test is not ideal:
> 
> utsname01.c:39: TDEBUG: mmap((nil), 64, PROT_READ | PROT_WRITE(3), 33, -1, 0)
> utsname01.c:40: TDEBUG: mmap((nil), 64, PROT_READ | PROT_WRITE(3), 33, -1, 0)
> 
> but better more output code than no code.

Well, I don't like that noisy logging style, that's why I did aa5a6fcdcd.

Maybe can we add more levels of TDEBUG log to LTP:

  -D0: no debug logs print
  -D1: only generic logs print
  -D2: more veroes logs include library debuginfo

What do you think?

-- 
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp