From: Cyril Hrubis <chrubis@suse.cz>
To: Jinseok Kim <always.starving0@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] poll: add basic POLLHUP semantics test
Date: Wed, 25 Feb 2026 11:37:44 +0100 [thread overview]
Message-ID: <aZ7Q-PB-_LV2K1xK@yuki.lan> (raw)
In-Reply-To: <20260224171609.47265-1-always.starving0@gmail.com>
Hi!
> + TEST(poll(&pfd, 1, -1));
> +
> + if (TST_RET == -1) {
> + tst_res(TFAIL | TTERRNO, "poll() failed");
> + return;
> + } else if (TST_RET != 1) {
> + tst_res(TFAIL, "Unexpected poll() return value %ld", TST_RET);
> + return;
> + }
No need for the else here. We do return in the previous if () block.
Otherwise:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-02-25 10:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 16:36 [LTP] [PATCH 1/2] poll: add basic POLLHUP semantics test Jinseok Kim
2026-02-19 16:36 ` [LTP] [PATCH 2/2] poll: add test for POLLNVAL on invalid fd Jinseok Kim
2026-02-20 10:05 ` Cyril Hrubis
2026-02-21 13:33 ` [LTP] [PATCH v2 1/2] poll: add basic POLLHUP semantics test Jinseok Kim
2026-02-21 13:40 ` Jinseok Kim
2026-02-21 13:40 ` [LTP] [PATCH v2 2/2] poll: add test for POLLNVAL on invalid fd Jinseok Kim
2026-02-24 15:36 ` Cyril Hrubis
2026-02-24 17:15 ` [LTP] [PATCH v3 1/2] poll: add basic POLLHUP semantics test Jinseok Kim
2026-02-24 17:15 ` [LTP] [PATCH v3 2/2] poll: add test for POLLNVAL on invalid fd Jinseok Kim
2026-02-25 10:36 ` Cyril Hrubis
2026-02-25 10:37 ` Cyril Hrubis [this message]
2026-02-25 11:28 ` [LTP] [PATCH v4 1/2] poll: add basic POLLHUP semantics test Jinseok Kim
2026-02-25 11:28 ` [LTP] [PATCH v4 2/2] poll: add test for POLLNVAL on invalid fd Jinseok Kim
2026-02-25 11:34 ` Andrea Cervesato via ltp
2026-02-25 11:34 ` [LTP] [PATCH v4 1/2] poll: add basic POLLHUP semantics test Andrea Cervesato via ltp
2026-02-25 11:39 ` [LTP] [PATCH v3 " Andrea Cervesato
2026-02-24 15:31 ` [LTP] [PATCH v2 " Cyril Hrubis
2026-02-24 17:02 ` Jinseok Kim
2026-02-20 9:51 ` [LTP] [PATCH " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ7Q-PB-_LV2K1xK@yuki.lan \
--to=chrubis@suse.cz \
--cc=always.starving0@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox