Re: [LTP] [PATCH v2 1/6] doc: INSTALL: dma_thread_diotest.c: Remove runltp from doc

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Remove runltp from all doc, replace it with kirk.
> Also replace the old runltp-ng with kirk.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  INSTALL                                            |  4 +++-
>  doc/developers/test_case_tutorial.rst              |  6 +++---
>  doc/developers/todo.rst                            | 10 ----------
>  metadata/README.md                                 |  2 +-
>  testcases/kernel/fs/fs_readonly/test_robind.sh     |  2 +-
>  testcases/kernel/io/direct_io/dma_thread_diotest.c |  3 +--
>  testcases/kernel/security/smack/README             |  2 +-
>  testcases/network/can/filter-tests/INSTALL         |  2 +-
>  testcases/network/rpc/rpc-tirpc/README             |  2 +-
>  testscripts/Readme_ROBind                          |  4 ++--
>  10 files changed, 14 insertions(+), 23 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index c44bb4e660..9ef929a971 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -105,9 +105,9 @@ Quick Start
>  	$ ./configure
>  	$ make all
>  	# make install
        ^
	This should be $ (not caused by this patch but worth fixing)
> -	$ /opt/ltp/runltp
>  
>  *NOTE:
> +- For running tests use kirk [1], individual test you can run directly.
                                                    ^
					 This sentece has wrong order of words.

And also oversimplifies things, there is no mention of setting correct
PATH that needs to be done in order to run these tests.

I would just drop that and leave only the first sentence.

>  - LTP assumes the existence of the nobody, bin, and daemon users and their
>  groups.  If these IDs do not exist, certain tests will fail. The respective
>  user and group IDs should be the same, i.e. if `nobody's' user ID is 99, then
> @@ -117,6 +117,8 @@ its group ID should also be 99. The names of the groups are irrelevant.
>  DESTDIR= is also honored for install and will install into $DESTDIR/$prefix,
>  if you want to install into a chroot or a rootfs for instance.
>  
> +[1] https://github.com/linux-test-project/kirk
> +
>  Detailed Installation
>  ---------------------
>  
> diff --git a/doc/developers/test_case_tutorial.rst b/doc/developers/test_case_tutorial.rst
> index 08bd1b1519..240897e36b 100644
> --- a/doc/developers/test_case_tutorial.rst
> +++ b/doc/developers/test_case_tutorial.rst
> @@ -205,9 +205,9 @@ please do:
>  
>  This should build the test and then run it. However, even though the test is
>  in :master:`testcases/kernel/syscalls` directory it won't be automatically ran
> -as part of the syscalls test group (e.g. not run via ``kirk -r math`` or
> -``./runltp -f syscalls``). For this we need to add it to the runtest file. So
> -open :master:`runtest/syscalls` and add the lines starting with a ``+``.
> +as part of the syscalls test group (e.g. not run via ``kirk -r math``.  For
                                                                        ^
									missing
									closing
									)

Also the path to syscalls is missing after the change.

> +this we need to add it to the runtest file. So open :master:`runtest/syscalls`
> +and add the lines starting with a ``+``.
>  
>  .. code-block::

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp