public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Jinseok Kim <always.starving0@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] inotify: cleanup - limit masks, use SAFE_ wrappers
Date: Thu, 19 Feb 2026 17:08:47 +0100	[thread overview]
Message-ID: <aZc1j_HZeoZRdYi6@yuki.lan> (raw)
In-Reply-To: <20260214175237.13794-1-always.starving0@gmail.com>

Hi!
> -	wd = SAFE_MYINOTIFY_ADD_WATCH(fd_notify, fname, IN_ALL_EVENTS);
> +	wd = SAFE_MYINOTIFY_ADD_WATCH(fd_notify, fname, IN_ATTRIB | IN_OPEN |
> +				      IN_ACCESS | IN_CLOSE_NOWRITE | IN_MODIFY |
> +				      IN_CLOSE_WRITE);

I had a short discussion about this with Jan Kara and we agreed to keep
the IN_ALL_EVENTS here. The rationale is that if kernel starts sending
unexpected events we want the test to fail instead of filtering them
out.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-02-19 16:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14 17:52 [LTP] [PATCH] inotify: cleanup - limit masks, use SAFE_ wrappers Jinseok Kim
2026-02-16 10:20 ` Petr Vorel
2026-02-16 16:50   ` Jinseok Kim
2026-02-17 13:29     ` Andrea Cervesato via ltp
2026-02-19 16:08 ` Cyril Hrubis [this message]
2026-02-19 18:04   ` [LTP] [PATCH v2] " Jinseok Kim
2026-02-20 10:43     ` Cyril Hrubis
2026-02-20 14:08       ` Jinseok Kim
2026-02-20 15:05         ` Cyril Hrubis
2026-02-21  8:21           ` [LTP] [PATCH v3] inotify: modernize with " Jinseok Kim
2026-02-23 16:59             ` Cyril Hrubis
2026-02-24 13:32             ` Andrea Cervesato via ltp
2026-02-24 13:34             ` Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZc1j_HZeoZRdYi6@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=always.starving0@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox