From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E93FAFC5913 for ; Thu, 26 Feb 2026 08:59:55 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 4B5113CB486 for ; Thu, 26 Feb 2026 09:59:54 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 1D1E33C5489 for ; Thu, 26 Feb 2026 09:59:34 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id E06B2200266 for ; Thu, 26 Feb 2026 09:59:32 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4F6E15BE2B; Thu, 26 Feb 2026 08:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772096371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iEbZZAjWTdDfFzzkMEgyWsXeaQELgrPlzT6njEpC4Nc=; b=Pd59HKxKeapRPqoPyCHPJukhHGKXL/lxkGr6FDB6JU2bXFpTRi+K1myvmU76OBSj2hNuRi ezb/XcQeYkgOfpkRsMnJiWTLkAQgpSNuASvy5dmBtOBkHOGt7i7rCB53o5ulflkX3OciTy vK7gU/KwDd+JdzR/beqMR9Sp8rQKFvA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772096371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iEbZZAjWTdDfFzzkMEgyWsXeaQELgrPlzT6njEpC4Nc=; b=ZHvt4eNjz9YzEfY5DmlLjL8Ih+z8k3NDTp6idFG5vayN4TFBE6xtmGG/DRrZKUoq9hKULu cyINQNsMWtNXHiAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Pd59HKxK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZHvt4eNj DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772096371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iEbZZAjWTdDfFzzkMEgyWsXeaQELgrPlzT6njEpC4Nc=; b=Pd59HKxKeapRPqoPyCHPJukhHGKXL/lxkGr6FDB6JU2bXFpTRi+K1myvmU76OBSj2hNuRi ezb/XcQeYkgOfpkRsMnJiWTLkAQgpSNuASvy5dmBtOBkHOGt7i7rCB53o5ulflkX3OciTy vK7gU/KwDd+JdzR/beqMR9Sp8rQKFvA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772096371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iEbZZAjWTdDfFzzkMEgyWsXeaQELgrPlzT6njEpC4Nc=; b=ZHvt4eNjz9YzEfY5DmlLjL8Ih+z8k3NDTp6idFG5vayN4TFBE6xtmGG/DRrZKUoq9hKULu cyINQNsMWtNXHiAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 34E663EA62; Thu, 26 Feb 2026 08:59:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cSabC3MLoGmtNQAAD6G6ig (envelope-from ); Thu, 26 Feb 2026 08:59:31 +0000 Date: Thu, 26 Feb 2026 09:59:35 +0100 From: Cyril Hrubis To: Wei Gao Message-ID: References: <20251125044057.20922-1-wegao@suse.com> <20260225015044.19233-1-wegao@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim, suse.cz:email, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 4F6E15BE2B X-Virus-Scanned: clamav-milter 1.0.9 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4] tst_tmpdir: Fix buffer overflow in tst_tmpdir.c X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > diff --git a/lib/tst_tmpdir.c b/lib/tst_tmpdir.c > index 9b024a74e..0c06a306c 100644 > --- a/lib/tst_tmpdir.c > +++ b/lib/tst_tmpdir.c > @@ -186,8 +186,10 @@ static int purge_dirat(int dir_fd, const char *path, char **errptr) > continue; > > /* Recursively remove the current entry */ > - if (rmobjat(subdir_fd, dir_ent->d_name, errptr) != 0) > + if (rmobjat(subdir_fd, dir_ent->d_name, errptr) != 0) { > + close(subdir_fd); <<<<<<<<<< first close > ret_val = -1; > + } > } > > closedir(dir); <<<<<<<<<<<<< second close Ah, right, we hand the fd to the fdopendir() and it's closed in the closedir() call. I've missed that since the closedir() is not shown in the diff since that part of the code wasn't modified and haven't shown up in the diff. The patch looks good to me then. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp