From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3BD0E9B34D for ; Mon, 2 Mar 2026 10:00:07 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 776C03D7BD2 for ; Mon, 2 Mar 2026 11:00:06 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 607273C4C64 for ; Mon, 2 Mar 2026 10:59:47 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id B07DA1000946 for ; Mon, 2 Mar 2026 10:59:46 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B2AC43F823; Mon, 2 Mar 2026 09:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772445585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gqBSyV5PL7jQFZWoJYdR4TC1110JfVTvhmobTe4LuM4=; b=BI7Sl+kT34Zyu2gW+116c5eVJRsin7b/Htt+wVTEZ2wYp6PG7ux5mrYfOlSbaqGdW9VvJF t53Pjde1EOdza2qCVpKEg9LqR3T/nXOowALxTRfi/oc//ZGBP4DBHWMr3vcA3m9zBXxYkh tKE/olARxy+OWm4+eWctOeRKGROyCNg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772445585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gqBSyV5PL7jQFZWoJYdR4TC1110JfVTvhmobTe4LuM4=; b=pmWk9kyinj/EYZUgnQ3w4WASkKNSQ+cRsMi+xV5w7veDBPgnH4NLwiedY+P6qbT4LYDaFE pEb6i5VoWRoee9BQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BI7Sl+kT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pmWk9kyi DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772445585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gqBSyV5PL7jQFZWoJYdR4TC1110JfVTvhmobTe4LuM4=; b=BI7Sl+kT34Zyu2gW+116c5eVJRsin7b/Htt+wVTEZ2wYp6PG7ux5mrYfOlSbaqGdW9VvJF t53Pjde1EOdza2qCVpKEg9LqR3T/nXOowALxTRfi/oc//ZGBP4DBHWMr3vcA3m9zBXxYkh tKE/olARxy+OWm4+eWctOeRKGROyCNg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772445585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gqBSyV5PL7jQFZWoJYdR4TC1110JfVTvhmobTe4LuM4=; b=pmWk9kyinj/EYZUgnQ3w4WASkKNSQ+cRsMi+xV5w7veDBPgnH4NLwiedY+P6qbT4LYDaFE pEb6i5VoWRoee9BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A0BCD3EA69; Mon, 2 Mar 2026 09:59:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id atMSJpFfpWk+EgAAD6G6ig (envelope-from ); Mon, 02 Mar 2026 09:59:45 +0000 Date: Mon, 2 Mar 2026 10:59:54 +0100 From: Cyril Hrubis To: Li Wang Message-ID: References: <20260301012808.15588-1-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260301012808.15588-1-liwang@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.991]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:dkim,suse.cz:email,yuki.lan:mid]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim, suse.cz:email, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Queue-Id: B2AC43F823 X-Virus-Scanned: clamav-milter 1.0.9 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] lib: Extend -D flag to support multiple debug levels X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > This patch extends the LTP debugging framework by introducing multiple > levels of verbosity for the '-D' command line option. Instead of a simple > on/off toggle, it now allows developers to specify whether they want debug > output exclusively from the test process, or from both the test and library > processes. > > The supported debug levels are: > -D0 : Disable all debug logs (default behavior) > -D1 (-D): Enable debug logs for the test process only > -D2 : Enable verbose debug logs for both the test and library processes > > Signed-off-by: Li Wang > --- > doc/developers/debugging.rst | 6 ++++++ > lib/tst_test.c | 25 +++++++++++++++---------- > 2 files changed, 21 insertions(+), 10 deletions(-) > > diff --git a/doc/developers/debugging.rst b/doc/developers/debugging.rst > index 181e5b096..8b5550b73 100644 > --- a/doc/developers/debugging.rst > +++ b/doc/developers/debugging.rst > @@ -12,6 +12,12 @@ The LTP framework supports ``TDEBUG`` flag test debug messages. These > messages can be enabled using the ``-D`` parameter or setting ``LTP_ENABLE_DEBUG=1`` > environment variable (see :doc:`../users/setup_tests`). > > +The ``-D`` parameter also supports the following verbosity levels: > + > + ``-D0``: Disable all debug logs (default behavior). > + ``-D1`` (or ``-D``): Enable debug logs for the test process only. > + ``-D2``: Enable verbose debug logs for both the test and library processes. > + > Tracing and debugging syscalls > ------------------------------ > > diff --git a/lib/tst_test.c b/lib/tst_test.c > index 239494b6f..f7907223e 100644 > --- a/lib/tst_test.c > +++ b/lib/tst_test.c > @@ -83,7 +83,7 @@ struct context { > tst_atomic_t abort_flag; > uint32_t mntpoint_mounted:1; > uint32_t ovl_mounted:1; > - uint32_t tdebug:1; > + uint32_t tdebug; > }; > > struct results { > @@ -217,7 +217,7 @@ void tst_reinit(void) > tst_max_futexes = (size - offsetof(struct ipc_region, futexes)) / sizeof(futex_t); > > if (context->tdebug) > - tst_res(TINFO, "Restored metadata for PID %d", getpid()); > + tst_res(TDEBUG, "Restored metadata for PID %d", getpid()); I suppose that we do not need the if (context->tdebug) now. Otherwise it looks good. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp